Bug 452806 (ember-media)
| Summary: | Review Request: ember-media - media files for the ember | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexey Torkhov <atorkhov> | ||||
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review, huzaifas, notting, tcallawa, wart | ||||
| Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-09-12 07:26:21 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Alexey Torkhov
2008-06-25 08:01:59 UTC
there is a typo:
Requires: ember >= ${version}
should be:
Requires: ember >= %{version}
Thanks. I'm mixing $ and % quite often :) Spec URL: http://purple.worldforge.org/~alex/fedora/ember-media.spec SRPM URL: http://purple.worldforge.org/~alex/fedora/ember-media-0.5.3-1.src.rpm (176M) Update to 0.5.3. Spec URL: http://purple.worldforge.org/~alex/fedora/ember-media.spec SRPM URL: http://purple.worldforge.org/~alex/fedora/ember-media-0.5.4-1.src.rpm (180M) Update to 0.5.4. Created attachment 316476 [details]
spec changes to cleanup rpmlint failures
I've attached a diff between your last spec file, and one I edited to fix the rpmlint errors: This review is against the fixed spec and SRPM. Please make those changes before committing. Good: - rpmlint checks return: ember-media.noarch: W: dangling-relative-symlink /usr/share/ember/media/shared/common/themes/ember/gui/fonts/VeraBd.ttf ../../../../../../../../fonts/bitstream-vera/VeraBd.ttf ember-media.noarch: W: dangling-relative-symlink /usr/share/ember/media/shared/common/themes/ember/gui/fonts/Vera.ttf ../../../../../../../../fonts/bitstream-vera/Vera.ttf ember-media.noarch: W: dangling-relative-symlink /usr/share/ember/media/shared/core/Vera.ttf ../../../../fonts/bitstream-vera/Vera.ttf These are safe to ignore, because you have Requires: bitstream-vera-fonts - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+ or GFDL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (1bd54d49063505c63ea9f4548711749b7e75a553) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - content okay - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Please be sure you make my changes before you commit, but this is APPROVED. Will apply your patch! Thanks! New Package CVS Request ======================= Package Name: ember-media Short Description: Ember media files Owners: atorkhov wart Branches: F-9 InitialCC: cvs done Huzaifa, package is in place, but I cannot find cvs module. Resolved in IRC. |