Bug 453858
Summary: | Review Request: globus-gsi-callback - Globus Toolkit - Globus GSI Callback Library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mattias Ellert <mattias.ellert> |
Component: | Package Review | Assignee: | Thomas Sailer <fedora> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, fedora, notting |
Target Milestone: | --- | Flags: | fedora:
fedora-review+
dennis: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 1.10-1.fc11 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-05-09 04:21:19 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 453847, 453848, 453850, 453851, 453853, 453854, 453855, 453856, 453857 | ||
Bug Blocks: | 453815, 453861, 453865, 467237 |
Description
Mattias Ellert
2008-07-02 22:23:48 UTC
New version based on the globus toolkit 4.2.1 release: SRPM: http://www.grid.tsl.uu.se/repos/globus/fedora/9/src/SRPMS/globus-gsi-callback-1.10-0.2.fc9.src.rpm SPEC: http://www.grid.tsl.uu.se/repos/globus/fedora/9/info/globus-gsi-callback.spec All applied patches submitted upstream: Use .la files when linking within a package: http://bugzilla.globus.org/bugzilla/show_bug.cgi?id=6476 Patch accepted upstream: http://viewcvs.globus.org/viewcvs.cgi/gsi/callback/source/library/Makefile.am?r1=1.6&r2=1.7 This package was updated due to the renaming of the GPT package. SRPM: http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/globus-gsi-callback-1.10-0.3.fc10.src.rpm SPEC: http://www.grid.tsl.uu.se/repos/globus/info/globus-gsi-callback.spec New version - Added s390x as 64 bit arch - Added comment documenting source - Adapt to changes in the globus-core package http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/globus-gsi-callback-1.10-0.5.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/globus-gsi-callback.spec Package updated due to new packaging guidelines - Change defines to globals - Remove explicit requires on library packages http://www.grid.tsl.uu.se/repos/globus/info/new/globus-gsi-callback-1.10-1.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/new/globus-gsi-callback.spec Draft packaging guidelines for Globus packages are now available: http://fedoraproject.org/wiki/PackagingDrafts/Globus Source matches upstream: $ diff -urN globus_gsi_callback-1.10 globus_gsi_callback-1.10-dl is silent. Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1330235 Rpmlint: $ rpmlint globus-gsi-callback* globus-gsi-callback.spec globus-gsi-callback-devel.x86_64: W: no-documentation 4 packages and 2 specfiles checked; 0 errors, 1 warnings. Fedora review globus-gsi-callback-1.10-1.fc10.src.rpm 2009-04-30 + OK ! needs attention + rpmlint output The no-documentation warning can be ignored as there is a separate doc package + Package is named according to Fedora Package Naming Guidelines + Specfile name matches the package base name + Package follows the Fedora packaging guidelines + License meets guidelines and is acceptable to Fedora ASL 2.0 + License matches the actual package license + The package contains the license file + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm the source repacking makes it impossible to compare md5sum's, thus: $ diff -urN globus_gsi_callback-1.10 globus_gsi_callback-1.10-dl reports no differences + Package scratch-builds n/a ExcludeArch bugs filed + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun + Does not use Prefix: /usr + Package owns all directories it creates + No duplicate files in %files + %files has %defattr + %clean contains rm -rf $RPM_BUILD_ROOT + Consistent use of macros + Package must contain code or permissible content + Large documentation files should go in -doc subpackage n/a Files marked %doc should not affect package + Header files should be in -devel n/a Static libraries should be in -static + Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' indirectly, via globus-core + libfoo.so must go in -devel + -devel must require the fully versioned base + Packages should not contain libtool .la files n/a Packages containing GUI apps must include %{name}.desktop file + Packages must not own files or directories owned by other packages + %install begins with rm -rf $RPM_BUILD_ROOT + Filenames must be valid UTF-8 APPROVED by sailer. Thank you for the review. New Package CVS Request ======================= Package Name: globus-gsi-callback Short Description: Globus Toolkit - Globus GSI Callback Library Owners: ellert Branches: F-9 F-10 F-11 EL-4 EL-5 InitialCC: CVS Done Package available in devel. globus-gsi-callback-1.10-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/globus-gsi-callback-1.10-1.fc10 globus-gsi-callback-1.10-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/globus-gsi-callback-1.10-1.fc9 globus-gsi-callback-1.10-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. globus-gsi-callback-1.10-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. globus-gsi-callback-1.10-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/globus-gsi-callback-1.10-1.fc11 globus-gsi-callback-1.10-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |