Bug 454015
| Summary: | Review Request: tcl-tile - Modified Tk styling engine | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bashton, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
tcallawa: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-09-14 03:15:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 454017, 454022 | ||
|
Description
Tom "spot" Callaway
2008-07-03 20:14:21 UTC
- rpmlint checks return: tcl-tile-devel.i386: W: no-documentation but that's ok. Devel don't have to own some documentation. - package meets naming guidelines OK - package meets packaging guidelines OK - license: Please check the license: http://fedoraproject.org/wiki/Licensing/TCL The source code is from tcl developers and it looks more tclish to me than MIT. - spec file legible, in am. english - probably OK - source matches upstream OK - package compiles on devel (x86) - check this latter - no missing BR - no unnecessary BR - no locales OK - not relocatable OK - owns all directories that it creates OK - no duplicate files OK - permissions ok OK - %clean OK - macro use consistent OK - docs OK - nothing in %doc affects runtime OK - devel package OK - no .la files OK - post/postun ldconfig no, OK - devel requires base package n-v-r OK You're right, license should be TCL. New SRPM: http://www.auroralinux.org/people/spot/review/new/tcl-tile-0.8.2-2.fc10.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/new/tcl-tile.spec http://koji.fedoraproject.org/koji/taskinfo?taskID=792855 koji build pass. The license has been fixed. New Package CVS Request ======================= Package Name: tcl-tile Short Description: Modified Tk styling engine Owners: spot Branches: F-8 F-9 devel InitialCC: ... and it's done. tcl-tile-0.8.2-2.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/tcl-tile-0.8.2-2.fc8 tcl-tile-0.8.2-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/tcl-tile-0.8.2-2.fc9 Built in rawhide too. tcl-tile-0.8.2-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. tcl-tile-0.8.2-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |