Red Hat Bugzilla – Bug 454015
Review Request: tcl-tile - Modified Tk styling engine
Last modified: 2008-09-16 19:29:18 EDT
Spec URL: http://auroralinux.org/people/spot/review/coccinella/tcl-tile.spec
SRPM URL: http://auroralinux.org/people/spot/review/coccinella/tcl-tile-0.8.2-1.fc10.src.rpm
The Tile Widget Set is an experimental reimplementation of
some of the core Tk widgets. The primary purpose is
to generate ideas for how to build the next generation of Tk,
when the asteroid strikes and we prepare for the 9.0 release.
- rpmlint checks return:
tcl-tile-devel.i386: W: no-documentation
but that's ok. Devel don't have to own some documentation.
- package meets naming guidelines OK
- package meets packaging guidelines OK
Please check the license: http://fedoraproject.org/wiki/Licensing/TCL
The source code is from tcl developers and it looks more tclish to me than MIT.
- spec file legible, in am. english - probably OK
- source matches upstream OK
- package compiles on devel (x86) - check this latter
- no missing BR
- no unnecessary BR
- no locales OK
- not relocatable OK
- owns all directories that it creates OK
- no duplicate files OK
- permissions ok OK
- %clean OK
- macro use consistent OK
- docs OK
- nothing in %doc affects runtime OK
- devel package OK
- no .la files OK
- post/postun ldconfig no, OK
- devel requires base package n-v-r OK
You're right, license should be TCL.
New SRPM: http://www.auroralinux.org/people/spot/review/new/tcl-tile-0.8.2-2.fc10.src.rpm
New SPEC: http://www.auroralinux.org/people/spot/review/new/tcl-tile.spec
koji build pass. The license has been fixed.
New Package CVS Request
Package Name: tcl-tile
Short Description: Modified Tk styling engine
Branches: F-8 F-9 devel
... and it's done.
tcl-tile-0.8.2-2.fc8 has been submitted as an update for Fedora 8.
tcl-tile-0.8.2-2.fc9 has been submitted as an update for Fedora 9.
Built in rawhide too.
tcl-tile-0.8.2-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
tcl-tile-0.8.2-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.