Bug 454017
| Summary: | Review Request: tcl-tileqt - QT widget support for Tile Toolkit | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
tcallawa: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-10-22 16:56:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 454015 | ||
| Bug Blocks: | 454022 | ||
|
Description
Tom "spot" Callaway
2008-07-03 20:17:27 UTC
OK source files match upstream:
b48430f22a3311cbaab1e5e9d5cd6b07 tileqt0.4b1.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible. License text not included upstream.
OK latest version is being packaged.
OK BuildRequires are proper.
OK %clean is present.
FAIL package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
Please check
http://koji.fedoraproject.org/koji/getfile?taskID=879976&name=build.log
I know how to fix this, but when I did, it exposed a bug in the coccinella stack, so I want to make sure I have that fixed before I go forward here. New SRPM: http://auroralinux.org/people/spot/review/coccinella/tcl-tileqt-0.4-0.2.b1.fc10.src.rpm New SPEC: http://auroralinux.org/people/spot/review/coccinella/tcl-tileqt.spec Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=884501 ACCEPT New Package CVS Request ======================= Package Name: tcl-tileqt Short Description: QT widget support for Tile Toolkit Owners: spot Branches: F-8 F-9 devel InitialCC: ... and it's done. Built in rawhide, F-8 and F-9 updates coming. tcl-tileqt-0.4-0.2.b1.fc8.1 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/tcl-tileqt-0.4-0.2.b1.fc8.1 tcl-tileqt-0.4-0.2.b1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/tcl-tileqt-0.4-0.2.b1.fc9 tcl-tileqt-0.4-0.2.b1.fc8.1 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. tcl-tileqt-0.4-0.2.b1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |