Bug 455443
Summary: | Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Miroslav Suchý <msuchy> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | dennis, fedora-package-review, notting, sand.paul |
Target Milestone: | --- | Flags: | msuchy:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-Filesys-Df-0.92-20.el7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-07-30 13:10:30 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 452450 |
Description
Miroslav Suchý
2008-07-15 15:00:59 UTC
Fixed: http://koji.fedoraproject.org/koji/taskinfo?taskID=733592 SPEC and SRPM are updated. rpmlint gave me perl-Filesys-Df.i386: E: zero-length /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/auto/Filesys/Df/Df.bs ==> is this really required? If not remove it. perl-Filesys-Df.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-Filesys-Df-0.92/README This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. Df.bs: it is bootstrap file for loading so library. Yes, it is zero length. And as far I tried now, it is working even when erase. But since other perl modules has same zero length file (like perl-DBI, perl-Compress-Raw-Bzip2), I'm not sure if I want to remove it. This file is executed by bootstrap statedment in Df.pm (see http://www.perl.com/doc/manual/html/lib/DynaLoader.html ) README - I'm not sure to what to do. Hmmm probably include patch to substitute this newlines (but it will be long patch). OK. I put into srpm patch to remove dos EOL. I left Df.bs on place. SPEC and SRPM are updated. sorry I forgot to put "How to fix wrong-file-end-of-line-encoding". here it is given http://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#wrong-file-end-of-line-encoding ==> sed -i 's/\r//' <file_to_strip> Regarding .bs files, I checked packages on F9 you mentioned in comment #4 but didn't find any .bs installed on my machine. Okay. I just had a look at perl-DBI build.log at http://kojipkgs.fedoraproject.org/packages/perl-DBI/1.601/4.fc9/data/logs/i386/build.log and there I see .bs is actually removed using find /var/tmp/perl-DBI-1.601-4.fc9-root-mockbuild -type f -name '*.bs' -empty -exec rm -f '{}' ';' So you should add to spec find $RPM_BUILD_ROOT -type f -name '*.bs' -empty -exec rm -f {} \; Aha, I now realize I checked rhel5 packages instead Fedora. And they have zero *.bs files. Nevertheless I fixed it. I will try to contact author of cpanspec to have this line autogenerated. SPEC and SRPM are updated. I really like to see people commenting updated (SPEC and SRPM)path by increasing release tag and adding changelog in SPEC each time they rebuild SRPM. I assume that updated SRPM is http://miroslav.suchy.cz/fedora/perl-Filesys-Df/perl-Filesys-Df-0.92-1.fc9.src.rpm Your package is not building still and failed with build.log http://koji.fedoraproject.org/koji/getfile?taskID=735939&name=build.log SRCRPM: http://miroslav.suchy.cz/fedora/perl-Filesys-Df/perl-Filesys-Df-0.92-2.fc9.src.rpm SPEC: http://miroslav.suchy.cz/fedora/perl-Filesys-Df/perl-Filesys-Df.spec Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=736579 $ rpmlint /home/msuchy/rpmbuild/SRPMS/perl-Filesys-Df-0.92-2.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=744642 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a8b0aa3e5151a8a6c8b3067625980934 Filesys-Df-0.92.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful! + Package perl-Filesys-Df-0.92-2.fc10 => Provides: Df.so perl(Filesys::Df) = 0.92 Requires: libc.so.6 libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) perl >= 0:5.006 perl(Carp) perl(DynaLoader) perl(Exporter) perl(strict) perl(vars) rtld(GNU_HASH) APPROVED New Package CVS Request ======================= Package Name: perl-Filesys-Df Short Description: Perl extension for filesystem disk space information Owners: msuchy Branches: devel F-9 EL-4 EL-5 InitialCC: Cvsextras Commits: yes cvs done. Package Change Request ====================== Package Name: perl-Filesys-Df New Branches: epel7 Owners: msuchy perl-Filesys-Df is used by the MailScanner (http://www.mailscanner.info/) product as a prerequisite. It would make life somewhat easier for installers if perl-Filesys-Df were available in EPEL 7. Please do not change fedora-review flag, that one is to mark if review was done (flipping back). Fedora-cvs flag is for asking another branch. But the request for new branch should come from maintainer (he may have some reason for not doing that). You should just ask maintainer (me) if he can build it for epel7 (yes I can). Package Change Request ====================== Package Name: perl-Filesys-Df New Branches: epel7 Owners: msuchy Git done (by process-git-requests). perl-Filesys-Df-0.92-20.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-Filesys-Df-0.92-20.el7 perl-Filesys-Df-0.92-20.el7 has been pushed to the Fedora EPEL 7 stable repository. |