Bug 455544

Summary:	Review Request: cx18-firmware - Firmware for Conexant cx23418-based video capture devices
Product:	[Fedora] Fedora	Reporter:	Jarod Wilson <jarod>
Component:	Package Review	Assignee:	Axel Thimm <Axel.Thimm>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	Axel.Thimm: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	20080628-1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-08-16 13:55:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jarod Wilson 2008-07-16 01:57:43 UTC

Spec URL: http://wilsonet.com/packages/cx18-firmware/cx18-firmware.spec
SRPM URL: http://wilsonet.com/packages/cx18-firmware/cx18-firmware-20080628-1.src.rpm
Description: This package contains the firmware for Conexant cx23418-based
video capture devices, such as the Hauppauge WinTV HVR-1600.

See http://ivtvdriver.org/index.php/Main_Page and/or the documentation in the tarball for additional details.

Comment 1 Axel Thimm 2008-07-16 05:55:41 UTC

Good:

- package meets naming guidelines
- package meets packaging guidelines
- firmware license OK, text in %doc, matches source
- spec file legible/english
- source matches upstream
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- does not need to own all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED

Comment 2 Jarod Wilson 2008-07-16 14:00:44 UTC

New Package CVS Request
=======================
Package Name: cx18-firmware
Short Description: Firmware for Conexant cx23418-based video capture devices
Owners: jwilson
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes


Nb: the intention here is to build in F8 and let that be inherited up through F9
and devel, since this is a noarch firmware package.

Comment 3 Kevin Fenzi 2008-07-16 16:06:29 UTC

cvs done.

Comment 4 Axel Thimm 2008-08-16 13:55:12 UTC

Packages are up since a while, closing on behalf of Jarod.