Bug 455575
Summary: | Review Request: dbus-c++ - Native C++ bindings for D-Bus | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Adel Gadllah <adel.gadllah> |
Component: | Package Review | Assignee: | Dan Horák <dan> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | dan:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-07-16 17:29:02 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Adel Gadllah
2008-07-16 11:32:41 UTC
Can you change the snapshot generation to include last commit id? You can see http://cvs.fedoraproject.org/viewcvs/rpms/xorg-x11-drv-nouveau/devel/xorg-x11-drv-nouveau.spec?rev=1.4&view=auto for an example. OK, done. New spec: http://tgmweb.at/gadllah/dbus-c++.spec New SRPM: http://tgmweb.at/gadllah/dbus-c++-0.5.0-0.2.20080716git1337c65.fc9.src.rpm formal review: OK source files match upstream OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (LGPLv2+). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. BAD compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). BAD debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths, correct scriptlets exists OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in devel subpackage. OK pkgconfig files in devel subpackage. OK no libtool .la droppings. OK not a GUI app. - wrong flags are passed to the compiler, looks like package's own - can't see any source files in the debuginfo package (depends on the flags issue) - and I would use the git-archive to generate the source archive, but that's not any blocker, it would decrease the size from 750 KB to only 50 KB ;-) (In reply to comment #3) > formal review: > BAD compiler flags are appropriate. Fixed. > BAD debuginfo package looks complete. Fixed. > - wrong flags are passed to the compiler, looks like package's own Fixed now. (see above) > - can't see any source files in the debuginfo package (depends on the flags issue) Fixed too. > - and I would use the git-archive to generate the source archive, but that's not > any blocker, it would decrease the size from 750 KB to only 50 KB ;-) Done. New spec: http://tgmweb.at/gadllah/dbus-c++.spec New SRPM: http://tgmweb.at/gadllah/dbus-c++-0.5.0-0.3.20080716git1337c65.fc9.src.rpm looks OK now, so this package is APPROVED Thanks for the review. --------- New Package CVS Request ======================= Package Name: dbus-c++ Short Description: Native C++ bindings for D-Bus Owners: drago01 Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. |