Bug 455575 - Review Request: dbus-c++ - Native C++ bindings for D-Bus
Review Request: dbus-c++ - Native C++ bindings for D-Bus
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Dan Horák
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-16 07:32 EDT by Adel Gadllah
Modified: 2008-07-16 13:29 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-07-16 13:29:02 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
dan: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Adel Gadllah 2008-07-16 07:32:41 EDT
Spec URL: http://tgmweb.at/gadllah/dbus-c++.spec
SRPM URL: http://tgmweb.at/gadllah/dbus-c++-0.5.0-0.1.20080716git.fc9.src.rpm
Description: 
Native C++ bindings for D-Bus for use in C++ programs.
Comment 1 Dan Horák 2008-07-16 07:46:16 EDT
Can you change the snapshot generation to include last commit id? You can see
http://cvs.fedoraproject.org/viewcvs/rpms/xorg-x11-drv-nouveau/devel/xorg-x11-drv-nouveau.spec?rev=1.4&view=auto
for an example.
Comment 3 Dan Horák 2008-07-16 09:38:50 EDT
formal review:

OK	source files match upstream
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible (LGPLv2+). License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
BAD	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (Rawhide/x86_64).
BAD	debuginfo package looks complete.
OK	rpmlint is silent.
OK	final provides and requires look sane.
N/A	%check is present and all tests pass.
OK	shared libraries are added to the regular linker search paths, correct
scriptlets exists
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	correct scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	headers in devel subpackage.
OK	pkgconfig files in devel subpackage.
OK	no libtool .la droppings.
OK	not a GUI app.


- wrong flags are passed to the compiler, looks like package's own
- can't see any source files in the debuginfo package (depends on the flags issue)
- and I would use the git-archive to generate the source archive, but that's not
any blocker, it would decrease the size from 750 KB to only 50 KB ;-)
Comment 4 Adel Gadllah 2008-07-16 10:25:57 EDT
(In reply to comment #3)
> formal review:

> BAD	compiler flags are appropriate.
Fixed.

> BAD	debuginfo package looks complete.
Fixed.

> - wrong flags are passed to the compiler, looks like package's own
Fixed now. (see above)
> - can't see any source files in the debuginfo package (depends on the flags issue)
Fixed too.
> - and I would use the git-archive to generate the source archive, but that's not
> any blocker, it would decrease the size from 750 KB to only 50 KB ;-)
Done.

New spec: http://tgmweb.at/gadllah/dbus-c++.spec
New SRPM: http://tgmweb.at/gadllah/dbus-c++-0.5.0-0.3.20080716git1337c65.fc9.src.rpm
Comment 5 Dan Horák 2008-07-16 10:47:18 EDT
looks OK now, so this package is APPROVED
Comment 6 Adel Gadllah 2008-07-16 10:59:40 EDT
Thanks for the review.
---------
New Package CVS Request
=======================
Package Name: dbus-c++
Short Description: Native C++ bindings for D-Bus
Owners: drago01
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes
Comment 7 Kevin Fenzi 2008-07-16 12:13:20 EDT
cvs done.

Note You need to log in before you can comment on or make changes to this bug.