Bug 455699
| Summary: | Review Request: cpqarrayd - daemon to monitor HP (compaq) arraycontrollers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Juran <djuran> |
| Component: | Package Review | Assignee: | Dan Horák <dan> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | dan:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 2.3-6.fc9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-07-18 23:07:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
David Juran
2008-07-17 08:35:53 UTC
I was preparing my own packages after the internal discussion some time ago, so I will review this one. OK source files match upstream: 9d76dfe75507eabcc9e406bc88eeab7a660b057f cpqarrayd-2.3.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (GPLv2+). License text not included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. N/A owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. some notes: - ask upstream to run automake with the "--copy" to include not the links but real copies of files in the source archive - I would enclose the support for IDA in #ifdef WITH_IDA/#endif instead of commenting it out, but that's not a blocker - and maybe we could work a bit on the IDA support ... this package is APPROVED New Package CVS Request ======================= Package Name: cpqarrayd Short Description: daemon to monitor HP (compaq) arraycontrollers Owners: djuran Branches: F-8 F-9 EL-4 EL-5 Cvsextras Commits: yes cvs done. cpqarrayd-2.3-6.fc9 has been submitted as an update for Fedora 9 cpqarrayd-2.3-6.fc8 has been submitted as an update for Fedora 8 cpqarrayd-2.3-6.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. cpqarrayd-2.3-6.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |