Red Hat Bugzilla – Bug 455699
Review Request: cpqarrayd - daemon to monitor HP (compaq) arraycontrollers
Last modified: 2008-07-23 03:02:34 EDT
Spec URL: http://people.redhat.com/djuran/cpqarrayd.spec
SRPM URL: http://people.redhat.com/djuran/cpqarrayd-2.3-3.fc9.src.rpm
Cpqarrayd is a daemon to monitor HP (compaq) arraycontrollers. It reports any
status changes, like failing disks, to the syslog and optionally to a remote
host using SNMP traps.
Cpqarrayd was part of the kernel-utils package back in Red Hat Linux 9 but was then left out in the cold when then package was split up into it's components.
The original source contains support for the old(?) IDA arrays but this functionality requires undocumented IOCTL:s, i.e. they are not available in the header files exported by the kernel. Rather then copying the IOCTL definitions from the kernel's source code, I've disabled support for the IDA arrays in the package presented here.
I was preparing my own packages after the internal discussion some time ago, so
I will review this one.
OK source files match upstream:
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible (GPLv2+). License text not included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
N/A owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
- ask upstream to run automake with the "--copy" to include not the links but
real copies of files in the source archive
- I would enclose the support for IDA in #ifdef WITH_IDA/#endif instead of
commenting it out, but that's not a blocker
- and maybe we could work a bit on the IDA support ...
this package is APPROVED
New Package CVS Request
Package Name: cpqarrayd
Short Description: daemon to monitor HP (compaq) arraycontrollers
Branches: F-8 F-9 EL-4 EL-5
Cvsextras Commits: yes
cpqarrayd-2.3-6.fc9 has been submitted as an update for Fedora 9
cpqarrayd-2.3-6.fc8 has been submitted as an update for Fedora 8
cpqarrayd-2.3-6.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
cpqarrayd-2.3-6.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.