Bug 456242
| Summary: | Review Request: gavl - A library for handling uncompressed audio and video data | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Chauvet (kwizart) <kwizart> |
| Component: | Package Review | Assignee: | Gwyn Ciesla <gwync> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, gwync, notting, zarko.pintar |
| Target Milestone: | --- | Flags: | gwync:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-04-10 10:33:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 454888 | ||
| Bug Blocks: | 456256, 496433 | ||
|
Description
Nicolas Chauvet (kwizart)
2008-07-22 13:39:20 UTC
Spec URL: http://kwizart.fedorapeople.org/SPECS/gavl.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/gavl-1.0.1-1.fc8.kwizart.src.rpm Description: A library for handling uncompressed audio and video data rpmlint: not even crickets. You have ldconfig in %post and %postun, do you not need them for -devel as well? COPYING is GPLv3. Code all says GPLv2+. Web site doesn't really specify. ?? Needs clarification. Using a patched bundled library, which is documented. OK. Looks great otherwise, full review very nearly done. Just need libgdither to be in rawhide so I can mock-test the BuildRequires. Hello, What happened with this packet? I want prepare frei0r-plugins for Fedora but I need this packet as dependency. I prepare this packet for Fedora 10 so please, if you want to see my spec and src: http://dl.getdropbox.com/u/728801/kdenlive/sources/gavl.spec http://dl.getdropbox.com/u/728801/kdenlive/sources/gavl-1.1.0-1.fc10.src.rpm Please see them. kind regards, Zarko Spec URL: http://kwizart.fedorapeople.org/SPECS/gavl.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/gavl-1.1.0-1.fc10.src.rpm Description: A library for handling uncompressed audio and video data Changelog: - Update to 1.1.0 - Disable buildtime CPU detection. rpmlint still silent. Code says GPLv2+, COPYING is GPLv3+, tag is GPLv3+. OK. Still awaiting libgdither in rawhide for mock build. What about ldconfig in %post and %postun for -devel? Mock build good. Does the explanation from 456256 apply here WRT ldconfig? Ping? (In reply to comment #7) > Mock build good. Does the explanation from 456256 apply here WRT ldconfig? Sorry, I tought to have already answeared. But yes, no needs for ldconfig call for -devel. Ok, then. APPROVED. New Package CVS Request ======================= Package Name: gavl Short Description: A library for handling uncompressed audio and video data Owners: kwizart Branches: F-10 F-9 Cvsextras Commits: yes cvs done. Imported and built for rawhide and F-10. Going to build for F-9? build failed on F-10 because libgdither wasn't within the buildroot. I hope it will be fixed on next push. I will close the bug once F-9/F-10 gavl got built. Gotcha. The same thing with gavl is blocking my rawhide mock build for frei0r-plugins. :) (In reply to comment #14) > build failed on F-10 because libgdither wasn't within the buildroot. > I hope it will be fixed on next push. I will close the bug once F-9/F-10 gavl > got built. I do not understand well what was happening here... I succesfully build libgdither, gavl and frei0r-plugins with mock and put all of these packages on my private repo...??!! newly built packages don't get automatically available to others build in stable Fedora branches. They need to be either requested to release engineer, either pushed to stable release. As libgdither is still in updates-testing... gavl cannot build on F-10/F-9. But it was released for rawhide. So other review can continue. (In reply to comment #17) > newly built packages don't get automatically available to others build in > stable Fedora branches. They need to be either requested to release engineer, > either pushed to stable release. Ah, now it is clear.... :) Thx, Zarko packages built and requested to updates-testing for Fedora stable releases. Thx for the reviews |