Bug 454888 - Review Request: libgdither - Library for applying dithering to PCM audio sources
Review Request: libgdither - Library for applying dithering to PCM audio sources
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jon Ciesla
Fedora Extras Quality Assurance
:
Depends On:
Blocks: RussianFedoraRemix 456242
  Show dependency treegraph
 
Reported: 2008-07-10 11:50 EDT by Nicolas Chauvet (kwizart)
Modified: 2009-05-02 00:21 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-03-24 16:41:53 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
limburgher: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Nicolas Chauvet (kwizart) 2008-07-10 11:50:53 EDT
Spec URL:
http://kwizart.fedorapeople.org/SPECS/libgdither.spec
SRPM URL:
http://kwizart.fedorapeople.org/SRPMS/libgdither-0.6-1.fc8.kwizart.src.rpm
Description: Library for applying dithering to PCM audio sources

This package has a fix that will allow gavl to use a shared version instead of an internal one.
Comment 1 Jon Ciesla 2008-10-10 12:26:49 EDT
rpmlint on srpm clean.

rpmlint on rpms:

libgdither-devel.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

Anything to put here?

License, naming, macros, scripts, all good.  Full review is very clean.  No BR issues evident after a mock build.

Other than the one minor bit above, we're ready to rock and/or roll.

I'll use my copies to start reviewing gavl.
Comment 2 Nicolas Chauvet (kwizart) 2008-10-16 10:40:29 EDT
Hello, and sorry for the late answear

I think the whole framework could have a issue.
Specially on lib64 system (mutlilibs systems using /usr/lib64 as a standard path for libs). And maybe we have a problem with -FPIC not been used on x86 system. (light library can avoid using Position independant Code for shared libs, but it cannot be prelinked and can gives selinux denials)

I'm still searching for package to test frei0r-plugins usability 
(for now i'm using my own package of LiVES but mlt could be a good candidate)

I will use my public/experimental repository for testing the whole framework against rawhide x86
Comment 3 Zarko (grof) 2009-03-19 03:45:18 EDT
Hello,

What happened with this packet?

I want prepare frei0r-plugins for Fedora but I need this packet as dependency.

I prepare this packet for Fedora 10 so please, if you want to see my spec and src:

http://dl.getdropbox.com/u/728801/kdenlive/sources/libgdither.spec

http://dl.getdropbox.com/u/728801/kdenlive/sources/libgdither-0.6-2.fc10.src.rpm

Please see them.

kind regards, Zarko
Comment 4 Nicolas Chauvet (kwizart) 2009-03-19 05:59:31 EDT
This package is still waiting for a reviewer.

@Zarko
You aren't a sponsored packager at this time, so you need to follow this:
https://fedoraproject.org/wiki/PackageMaintainers/Join

But since ExcludeArch is undeeded, as the package will build at least on our primary arches; Il will stay with:

Spec URL:
http://kwizart.fedorapeople.org/SPECS/libgdither.spec
SRPM URL:
http://kwizart.fedorapeople.org/SRPMS/libgdither-0.6-1.fc8.kwizart.src.rpm
Description: Library for applying dithering to PCM audio sources

@Jon
Any news from your side ?
Comment 5 Zarko (grof) 2009-03-19 06:38:19 EDT
(In reply to comment #4)
> This package is still waiting for a reviewer.
> 
> @Zarko
> You aren't a sponsored packager at this time, so you need to follow this:
> https://fedoraproject.org/wiki/PackageMaintainers/Join

Yes, because this packets are my first job and waiting so long.

At this moment I do not have any new packet for build so I do not know how I can be sponsored packager without completely new packets?

BTW, Why these packets are waiting so long for review?

(I mean on gavl and frei0r-plugins, too)
Comment 6 Zarko (grof) 2009-03-19 06:39:08 EDT
(In reply to comment #4)
> This package is still waiting for a reviewer.
> 
> @Zarko
> You aren't a sponsored packager at this time, so you need to follow this:
> https://fedoraproject.org/wiki/PackageMaintainers/Join

Yes, because this packets are my first job and waiting so long.

At this moment I do not have any new packet for build so I do not know how I can be sponsored packager without completely new packets?

BTW, Why these packets are waiting so long for review?

(I mean on gavl and frei0r-plugins, too)
Comment 7 Zarko (grof) 2009-03-19 06:41:02 EDT
(In reply to comment #4)
> This package is still waiting for a reviewer.
> 
> @Zarko
> You aren't a sponsored packager at this time, so you need to follow this:
> https://fedoraproject.org/wiki/PackageMaintainers/Join

Yes, because this packets are my first job and waiting so long.

At this moment I do not have any new packet for build so I do not know how I can be sponsored packager without completely new packets?

BTW, Why these packets are waiting so long for review?

(I mean on gavl and frei0r-plugins, too)
Comment 8 Zarko (grof) 2009-03-19 06:42:09 EDT
(In reply to comment #4)
> This package is still waiting for a reviewer.
> 
> @Zarko
> You aren't a sponsored packager at this time, so you need to follow this:
> https://fedoraproject.org/wiki/PackageMaintainers/Join

Yes, because this packets are my first job and waiting so long.

At this moment I do not have any new packet for build so I do not know how I can be sponsored packager without completely new packets?

BTW, Why these packets are waiting so long for review?

(I mean on gavl and frei0r-plugins, too)
Comment 9 Jon Ciesla 2009-03-19 09:43:38 EDT
Nicolas, I'll finish this review shortly, and move from there.
Comment 10 Jon Ciesla 2009-03-19 10:47:44 EDT
Looks good still, is there documentation that could go in -devel?  And are the issues you raised in #2 resolved?
Comment 11 Nicolas Chauvet (kwizart) 2009-03-23 21:47:51 EDT
I'm not worried about libgdither itself, I was able to link gavl with libgdither from my own repository (using mock). One can use the mock config files to start testing the packages built from my repository.
What will need more looks is the way the targetted binary (I was testing LiVES) will behaves with the frei0r-plugins
Comment 12 Jon Ciesla 2009-03-24 08:29:23 EDT
Ok, then APPROVED.  I'll move on down the chain.
Comment 13 Nicolas Chauvet (kwizart) 2009-03-24 08:41:36 EDT
New Package CVS Request
=======================
Package Name: libgdither
Short Description: Library for applying dithering to PCM audio sources
Owners: kwizart
Branches: F-10 F-9 EL-5
Cvsextras Commits: yes
Comment 14 Kevin Fenzi 2009-03-24 13:21:35 EDT
cvs done.

Note You need to log in before you can comment on or make changes to this bug.