Bug 456689

Also noticed in passing in .xsession-errors while playing with the bell settings:

Window manager warning: GConf key '/apps/metacity/general/visual_bell_type' is
set to an invalid value

(In reply to comment #0)
> The treeview for customizing theme sounds has some issues:
> 
> - A number of rows don't react at all to click or double click, such as
>   "Audible Bell" and everything under "Windows and Buttons"

We don't show well which sound rows are disabled right now. Those don't work
because you have "input feedback sounds" and "audible bell" disabled.

> - The other pop up a combo on click. The 'custom' selection just pops up 
>   a file chooser. 
>   When I select a custom sound, it does show up in the treeview, but the next
>   click pops up the combo again and there is no way to retain the previously
>   selected sound. Frustrating !

Cancelling the file chooser doesn't work? It should, easy to fix.

> - I've not been able to get sounds to play on double-click

I blame Lennart (you need the latest libgnome and gnome-settings-daemon
installed, and it should work). I'll test it out on my machine when it's a bit
rebased as well.

> My recommendations:
> 
> 1) Make the customization work in all rows

Actually, show better that the rows are supposed to be disabled.

> 2) Make the filechooser start out in /usr/share/sounds, currently it just
>   seems to add a bookmark to that location. 

Fair enough.

> 3) A more complicated (but cool) polish thing ould be to have audible preview
>    in the file chooser.

That should be pretty straight forward actually, if libcanberra allows that.

> 4) Steal the little cell renderer hack from nautilus with which is now displays
>    eject buttons for mounted volumes in the sidebar, and use it for a play
>    button.

Agreed.

(In reply to comment #1)
> Also noticed in passing in .xsession-errors while playing with the bell settings:
> 
> Window manager warning: GConf key '/apps/metacity/general/visual_bell_type' is
> set to an invalid value

That's metacity complaining. Which value is it set to? I think we set it to be
empty when the visual bell is disabled...

(In reply to comment #2)
> (In reply to comment #0)
> > The treeview for customizing theme sounds has some issues:
> > 
> > - A number of rows don't react at all to click or double click, such as
> >   "Audible Bell" and everything under "Windows and Buttons"
> 
> We don't show well which sound rows are disabled right now. Those don't work
> because you have "input feedback sounds" and "audible bell" disabled.

Ah, indeed. Thats not obvious at all. Those rows should be insensitive.
I can tell you how to do that.

> > - The other pop up a combo on click. The 'custom' selection just pops up 
> >   a file chooser. 
> >   When I select a custom sound, it does show up in the treeview, but the next
> >   click pops up the combo again and there is no way to retain the previously
> >   selected sound. Frustrating !
> 
> Cancelling the file chooser doesn't work? It should, easy to fix.

I don't even get that far. The next click brings up the combo, and if I just let
go, the value snaps back to "Default". I think the best may be to have the
previously selected custom sound as a value in the combo.

> > My recommendations:
> > 
> > 1) Make the customization work in all rows
> 
> Actually, show better that the rows are supposed to be disabled.

The easiest way to achive that is to add a boolean column to the model and
map it to the "sensitive" property of the cell renderers. Then update the
boolean value as the checkbox is toggled.

> > 3) A more complicated (but cool) polish thing ould be to have audible preview
> >    in the file chooser.
> 
> That should be pretty straight forward actually, if libcanberra allows that.

You want to use the GtkFileChooser::update-preview signal for that.

> 
> (In reply to comment #1)
> > Also noticed in passing in .xsession-errors while playing with the bell
settings:
> > 
> > Window manager warning: GConf key '/apps/metacity/general/visual_bell_type' is
> > set to an invalid value
> 
> That's metacity complaining. Which value is it set to? I think we set it to be
> empty when the visual bell is disabled...
>

It seems metacity only allows 'fullscreen' and 'frame_flash' as values.

(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #0)
> > > The treeview for customizing theme sounds has some issues:
> > > 
> > > - A number of rows don't react at all to click or double click, such as
> > >   "Audible Bell" and everything under "Windows and Buttons"
> > 
> > We don't show well which sound rows are disabled right now. Those don't work
> > because you have "input feedback sounds" and "audible bell" disabled.
> 
> Ah, indeed. Thats not obvious at all. Those rows should be insensitive.
> I can tell you how to do that.

Fixed.

> > > - The other pop up a combo on click. The 'custom' selection just pops up 
> > >   a file chooser. 
> > >   When I select a custom sound, it does show up in the treeview, but the next
> > >   click pops up the combo again and there is no way to retain the previously
> > >   selected sound. Frustrating !
> > 
> > Cancelling the file chooser doesn't work? It should, easy to fix.
> 
> I don't even get that far. The next click brings up the combo, and if I just let
> go, the value snaps back to "Default". I think the best may be to have the
> previously selected custom sound as a value in the combo.

You mean that it should show both "Custom..." and the last selected custom
sound? That'll be trickier, but I'll give it a spin.

> > > My recommendations:
> > > 
> > > 1) Make the customization work in all rows
> > 
> > Actually, show better that the rows are supposed to be disabled.
> 
> The easiest way to achive that is to add a boolean column to the model and
> map it to the "sensitive" property of the cell renderers. Then update the
> boolean value as the checkbox is toggled.

Sigh. 3 lines of difference or something. I thought I would have to spin my own
pango markup, and I really wasn't looking forward to that... I guess I should
file a bug somewhere about the documentation.

> > > 3) A more complicated (but cool) polish thing ould be to have audible preview
> > >    in the file chooser.
> > 
> > That should be pretty straight forward actually, if libcanberra allows that.
> 
> You want to use the GtkFileChooser::update-preview signal for that.

Will fix.

> > (In reply to comment #1)
> > > Also noticed in passing in .xsession-errors while playing with the bell
> settings:
> > > 
> > > Window manager warning: GConf key '/apps/metacity/general/visual_bell_type' is
> > > set to an invalid value
> > 
> > That's metacity complaining. Which value is it set to? I think we set it to be
> > empty when the visual bell is disabled...
> >
> 
> It seems metacity only allows 'fullscreen' and 'frame_flash' as values.

Fixed.

A few of those problems are now fixed upstream:
http://bugzilla.gnome.org/show_bug.cgi?id=542979

But still a few problems left:
http://bugzilla.gnome.org/show_bug.cgi?id=545056
http://bugzilla.gnome.org/show_bug.cgi?id=545055

I'll leave those to fix upstream.