Bug 456953

Summary:	Review Request: ocaml-mikmatch - OCaml extension for pattern matching with regexps
Product:	[Fedora] Fedora	Reporter:	Richard W.M. Jones <rjones>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	j: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://martin.jambon.free.fr/micmatch.html
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-08-24 10:05:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	456796

Description Richard W.M. Jones 2008-07-28 20:55:46 UTC

Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-mikmatch.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-mikmatch-1.0.0-1.fc10.src.rpm
Description: OCaml extension for pattern matching with regexps

Mikmatch (with a 'k') is the OCaml >= 3.10 version of Micmatch, an
extension for adding pattern matching with regular expressions to the
language.

The goal of Micmatch/Mikmatch is to make text-oriented programs even
easier to write, read and run without losing the unique and powerful
features of Objective Caml (OCaml).

Micmatch/Mikmatch provides a concise and highly readable syntax for
regular expressions, and integrates it into the syntax of OCaml thanks
to Camlp4.

Koji scratch build:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=744162

This package is rpmlint CLEAN.

$ rpm -q --requires -p ocaml-mikmatch-1.0.0-1.fc10.i386.rpm
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(VersionedDependencies) <= 3.0.3-1
ocaml(Arg) = 03e86a4154064ea900dc32c05f53e364
ocaml(Array) = aa8e3cd5824f9bb40b93fcd38d0c95b5
ocaml(Buffer) = f6cef633ea14963b84b79c4095c63dc3
ocaml(CamlinternalOO) = 6d0d5b328d6db88f403ca4393b4abd38
ocaml(Camlp4) = 1e46a133b8062d1571640f7fa36f32c4
ocaml(Camlp4_config) = cb716b4361f43326c6ad695c7a1bb5c0
ocaml(Camlp4_import) = 0134ca95282ef6821081c0c11802cea0
ocaml(Char) = e98bc9c9e918a84b3c1a5a122d42fac1
ocaml(Filename) = 633a1e7f590ff5e95124293dbef3b476
ocaml(Format) = 35fe566f7a37d8991a5c822bd1463949
ocaml(Hashtbl) = 083f2c94b44ff4e0b3220aaea6a783b4
ocaml(Int32) = 711321870c949bd3bbdd092d9bae92e4
ocaml(Int64) = f8f7e2e4c0667ead94596040b12e732d
ocaml(Lazy) = 8a4b5e7f0bdc6316df9264fd73cde981
ocaml(Lexing) = b1793496643444d3762dd42bebe2cfe3
ocaml(List) = da1ce9168f0408ff26158af757456948
ocaml(Map) = dedde7683d54ae7db1eb97cc868dd047
ocaml(Nativeint) = e79cdc4d3575c2ed044955cb7ef49aca
ocaml(Obj) = 5cfae708052c692ea39d23ed930fd64d
ocaml(Parsing) = 62cca107e4e88af303516459a87c3e9a
ocaml(Pcre) = 9cf03a45728e3cf29272c957775befee
ocaml(Pervasives) = 8ba3d1faa24d659525c9025f41fd0c57
ocaml(Printf) = 5dbbf45a03b54e6dbfcf39178d0d6341
ocaml(Queue) = caa3a209bfc63d23a30f573541a88fec
ocaml(Set) = 7da14e671a035f12386ace3890018ef3
ocaml(Str) = 56bb7ee61b2da83d42394686e3558fe4
ocaml(Stream) = 21a833e12efd34ea0c87d8d9da959809
ocaml(String) = 2c162ab314b2f0a2cfd22d471b2e21ab
ocaml(Sys) = 0da495f5a80f31899139359805318f28
ocaml(Unix) = 9a46a8db115947409e54686ada118599
ocaml(runtime) = 3.10.2

$ rpm -q --provides -p ocaml-mikmatch-1.0.0-1.fc10.i386.rpm
ocaml(Mikmatch) = 07d182b26c0f6d948b038a3af1b41469
ocaml(Run_mikmatch_pcre) = 44f39ac3e6ac55f6fbf917bddf8072cb
ocaml(Run_mikmatch_str) = 360adfb0137da51ec56cce62f91b7b6f
ocaml-mikmatch = 1.0.0-1.fc10

Upstream URL / more about micmatch/mikmatch here:
  http://martin.jambon.free.fr/micmatch.html

Comment 1 Jason Tibbitts 2008-08-20 20:03:58 UTC

Now to remember all of that ocaml knowledge I've flushed over the past couple of months....

* source files match upstream:
   daa5dcb1344979b9e08ac33a61e28d8beb998bcddc247df67b6f3f8b7d7290a5  
   mikmatch-1.0.0.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane (listed in the original report).
* %check is not present; no test suite upstream.  I have no idea at all about 
   testing this.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files (besides unnecessarily duplicated LICENSE file, not a 
   blocker).
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* .cma, .cmi, .so, .so.owner, META files in the main package.
* .a, .cmxa, .cmx and .mli files are in the -devel subpackage.
* .cmo, .ml files not included
* This is a parser extension, so .o files are OK in the main package.
* .so files have no rpath

APPROVED

Comment 2 Richard W.M. Jones 2008-08-20 20:40:57 UTC

Jason thanks for your hard work, as always.

Comment 3 Richard W.M. Jones 2008-08-20 20:42:12 UTC

New Package CVS Request
=======================
Package Name: ocaml-mikmatch
Short Description: OCaml extension for pattern matching with regexps
Owners: rjones
Branches: F-9
InitialCC: rjones

Comment 4 Kevin Fenzi 2008-08-23 17:59:55 UTC

cvs done.

Comment 5 Richard W.M. Jones 2008-08-24 10:05:36 UTC

F-10: http://koji.fedoraproject.org/koji/taskinfo?taskID=782459
F-9: http://koji.fedoraproject.org/koji/taskinfo?taskID=782480