Bug 457196

Summary:	Review Request: pymetar - METAR weather reports parser for Python
Product:	[Fedora] Fedora	Reporter:	Matthias Saou <matthias>
Component:	Package Review	Assignee:	Brian Pepple <bdpepple>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bdpepple, fedora-package-review, jeffperry_fedora, notting
Target Milestone:	---	Flags:	bdpepple: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-10-08 10:03:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	438608

Description Matthias Saou 2008-07-30 07:59:56 UTC

Spec URL: http://thias.fedorapeople.org/review/pymetar/pymetar.spec
SRPM URL: http://thias.fedorapeople.org/review/pymetar/pymetar-0.13-1.src.rpm
Description:
This library downloads the weather report for a given station ID, decodes it
and provides easy access to all the data found in the report.

NOTE: This is not the same library as the one already packaged as python-metar.

Comment 1 Jeff Perry 2008-07-31 01:45:58 UTC

**Unofficial quick look ** Looking for sponsor

Just looked at the spec file.
If I'm reading this right, the entire local python site-libs dir is included as
part of the generated package??

This is the line under %files...

%{python_sitelib}/*

This does not seem right...instead the package should declare a dependency on a
package or packages I would think.

If these python dependencies do not have packages in Fedora yet, then they may
need to have new ones created. 

If the actual dependency is only on standard parts of the default python install
then a dependency on python should be included.

Comment 2 Jeff Perry 2008-07-31 01:54:10 UTC

Never mind - closer inspection shows my interpretation is wrong.

Comment 3 Jeff Perry 2008-07-31 01:57:07 UTC

Never mind - closer inspection shows my interpretation is wrong.

Comment 4 Brian Pepple 2008-08-10 23:19:01 UTC

MD5Sum:
84b6737b101daf5647a60d0d93d7783a  pymetar-0.13.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Files have appropriate permissions and owners
* Rpmlint does not find problems
* Builds fine in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=769550
* Package installs and uninstalls cleanly

+1 APPROVE

Comment 5 Matthias Saou 2008-08-12 09:20:00 UTC

Thanks for your quick review, Brian!

New Package CVS Request
=======================
Package Name: pymetar
Short Description: METAR weather reports parser for Python
Owners: matthias
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2008-08-12 17:12:34 UTC

cvs done.

Comment 7 Matthias Saou 2008-10-08 10:03:27 UTC

Rebuilt the the packages a while back, but forgot to close this review. Doing so now. I've now updated to 0.14 too.