Bug 457492
| Summary: | Review Request: procbench - Multiplatform information tool and CPU benchmark for x86 procs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kairo Francisco de Araujo <kairo> |
| Component: | Package Review | Assignee: | Adel Gadllah <adel.gadllah> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, kevin, notting, pahan |
| Target Milestone: | --- | Flags: | adel.gadllah:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-10-12 15:14:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Kairo Francisco de Araujo
2008-08-01 00:21:06 UTC
$ rpmlint rpmbuild/SPECS/procbench.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/kairo/rpmbuild/SRPMS/procbench-0.8.2a-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/kairo/rpmbuild/RPMS/i386/procbench-0.8.2a-1.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/kairo/rpmbuild/RPMS/i386/procbench-debuginfo-0.8.2a-1.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Review
========
[+] source files match upstream:
2aaba7be4ecfe81e4349b7a1be7899c300faeaca
[+] package meets naming and versioning guidelines.
[-] specfile is properly named, is cleanly written and uses macros consistently:
Use "ExclusiveArch: i386 x86_64" instead of BuildArch
[+] dist tag is present.
[+] build root is correct.
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) is the
recommended value, but not the only one)
[+] license field matches the actual license.
[+] license is open source-compatible.
[+] license text included in package.
[+] latest version is being packaged.
[+] BuildRequires are proper.
[-] compiler flags are appropriate:
It does not use $RPM_OPT_FLAGS
[+] %clean is present.
[-] package builds in mock:
does not due to the BuildArch vs ExclusiveArch issue, see above.
[+] package installs properly.
[-] debuginfo package looks complete:
no due to wrong CFLAGS usage.
[+] rpmlint is silent.
[-] owns the directories it creates.
please own "%{_datadir}/%{name}/" (just removing the * after it should do it)
[+] doesn't own any directories it shouldn't.
[-] no duplicates in %files.
[+] file permissions are appropriate.
[+] no scriptlets present.
[+] code, not content.
[+] documentation is small, so no -docs subpackage is necessary.
[+] %docs are not necessary for the proper functioning of the package.
=======
Summary:
1) Use ExclusiveArch
2) Use proper CFLAGS
3) Fix the ownership issue
And I will approve it (rest looks good).
"[-] no duplicates in %files." Should be "[+] no duplicates in %files." - Fixed ExclusiveArch, ownership issue and proper CFLAGS SPEC File: http://kairo.fedorapeople.org/procbench/procbench.spec SRPM File: http://kairo.fedorapeople.org/procbench/procbench-0.8.2a-2.fc9.src.rpm $ rpmlint -i rpmbuild/SPECS/procbench.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint -i rpmbuild/SRPMS/procbench-0.8.2a-2.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint -i rpmbuild/RPMS/i386/procbench-0.8.2a-2.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint -i rpmbuild/RPMS/i386/procbench-debuginfo-0.8.2a-2.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Package looks fine now. => APPROVED New Package CVS Request ======================= Package Name: procbench Short Description: Multiplatform information tool and CPU benchmark for x86 procs Owners: kairo Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. Package imported and built so closing this one. |