Hide Forgot
Spec URL: http://kairo.fedorapeople.org/procbench/procbench.spec SRPM URL: http://kairo.fedorapeople.org/procbench/procbench-0.8.2a-1.fc9.src.rpm Description: Procbench is a multiplatform information tool and CPU benchmark for x86 processors. It tests memory transfer and math capabilities of your x86 processor. It includes programs (pb_g++ and pb_gcc) to get the best GCC optimisation parameters for a CPU.
$ rpmlint rpmbuild/SPECS/procbench.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/kairo/rpmbuild/SRPMS/procbench-0.8.2a-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/kairo/rpmbuild/RPMS/i386/procbench-0.8.2a-1.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/kairo/rpmbuild/RPMS/i386/procbench-debuginfo-0.8.2a-1.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Review ======== [+] source files match upstream: 2aaba7be4ecfe81e4349b7a1be7899c300faeaca [+] package meets naming and versioning guidelines. [-] specfile is properly named, is cleanly written and uses macros consistently: Use "ExclusiveArch: i386 x86_64" instead of BuildArch [+] dist tag is present. [+] build root is correct. (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) is the recommended value, but not the only one) [+] license field matches the actual license. [+] license is open source-compatible. [+] license text included in package. [+] latest version is being packaged. [+] BuildRequires are proper. [-] compiler flags are appropriate: It does not use $RPM_OPT_FLAGS [+] %clean is present. [-] package builds in mock: does not due to the BuildArch vs ExclusiveArch issue, see above. [+] package installs properly. [-] debuginfo package looks complete: no due to wrong CFLAGS usage. [+] rpmlint is silent. [-] owns the directories it creates. please own "%{_datadir}/%{name}/" (just removing the * after it should do it) [+] doesn't own any directories it shouldn't. [-] no duplicates in %files. [+] file permissions are appropriate. [+] no scriptlets present. [+] code, not content. [+] documentation is small, so no -docs subpackage is necessary. [+] %docs are not necessary for the proper functioning of the package. ======= Summary: 1) Use ExclusiveArch 2) Use proper CFLAGS 3) Fix the ownership issue And I will approve it (rest looks good).
"[-] no duplicates in %files." Should be "[+] no duplicates in %files."
- Fixed ExclusiveArch, ownership issue and proper CFLAGS SPEC File: http://kairo.fedorapeople.org/procbench/procbench.spec SRPM File: http://kairo.fedorapeople.org/procbench/procbench-0.8.2a-2.fc9.src.rpm $ rpmlint -i rpmbuild/SPECS/procbench.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint -i rpmbuild/SRPMS/procbench-0.8.2a-2.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint -i rpmbuild/RPMS/i386/procbench-0.8.2a-2.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint -i rpmbuild/RPMS/i386/procbench-debuginfo-0.8.2a-2.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Package looks fine now. => APPROVED
New Package CVS Request ======================= Package Name: procbench Short Description: Multiplatform information tool and CPU benchmark for x86 procs Owners: kairo Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes
cvs done.
Package imported and built so closing this one.