Bug 457545
| Summary: | Review Request: perl-Net-Ping-External - Cross-platform interface to ICMP "ping" utilities | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miloslav Trmač <mitr> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, otavio.cipriani, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-08-06 22:52:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 457888 | ||
|
Description
Miloslav Trmač
2008-08-01 13:05:03 UTC
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=756359 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 29c6cd74081861f4bffe1f83943f5792 Net-Ping-External-0.12.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package perl-Net-Ping-External-0.12-1.fc10 => Provides: perl(Net::Ping::External) = 0.12 Requires: perl(Carp) perl(Exporter) perl(Socket) perl(strict) perl(vars) APPROVED. New Package CVS Request ======================= Package Name: perl-Net-Ping-External Short Description: Cross-platform interface to ICMP "ping" utilities Owners: mitr Branches: F-9 InitialCC: perl-sig Cvsextras Commits: yes cvs done. CVS admins: Can you help, please? $ cvs -d :ext:mitr.redhat.com:/cvs/pkgs co perl-Net-Ping-External cvs server: cannot find module `perl-Net-Ping-External' - ignored cvs [checkout aborted]: cannot expand modules (Checking out perl-Net-RawIP, which was added roughly at the same time, works fine.) Sorry about that. Can you try again in about 20min or so? I think it's fixed. Thanks for the review! Package Change Request ====================== Package Name: perl-Net-Ping-External New Branches: el5 el6 Owners: mitr Please add this package to the EPEL repository. It is needed by GestioIP (http://www.gestioip.net/). I'm sorry, I'm won't be able to maintain this in EPEL. You are welcome to do so, if you want. |