Spec URL: http://people.redhat.com/mitr/packaging/perl-Net-Ping-External.spec SRPM URL: http://people.redhat.com/mitr/packaging/perl-Net-Ping-External-0.12-1.fc9.src.rpm Description: Net::Ping::External is a module which interfaces with the "ping" command on many systems. It presently provides a single function, ping(), that takes in a hostname and (optionally) a timeout and returns true if the host is alive, and false otherwise. Unless you have the ability (and willingness) to run your scripts as the superuser on your system, this module will probably provide more accurate results than Net::Ping will.
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=756359 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 29c6cd74081861f4bffe1f83943f5792 Net-Ping-External-0.12.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package perl-Net-Ping-External-0.12-1.fc10 => Provides: perl(Net::Ping::External) = 0.12 Requires: perl(Carp) perl(Exporter) perl(Socket) perl(strict) perl(vars) APPROVED.
New Package CVS Request ======================= Package Name: perl-Net-Ping-External Short Description: Cross-platform interface to ICMP "ping" utilities Owners: mitr Branches: F-9 InitialCC: perl-sig Cvsextras Commits: yes
cvs done.
CVS admins: Can you help, please? $ cvs -d :ext:mitr.redhat.com:/cvs/pkgs co perl-Net-Ping-External cvs server: cannot find module `perl-Net-Ping-External' - ignored cvs [checkout aborted]: cannot expand modules (Checking out perl-Net-RawIP, which was added roughly at the same time, works fine.)
Sorry about that. Can you try again in about 20min or so? I think it's fixed.
Thanks for the review!
Package Change Request ====================== Package Name: perl-Net-Ping-External New Branches: el5 el6 Owners: mitr Please add this package to the EPEL repository. It is needed by GestioIP (http://www.gestioip.net/).
I'm sorry, I'm won't be able to maintain this in EPEL. You are welcome to do so, if you want.