Bug 458025
| Summary: | Review Request: wsmancli - Opensource Implementation of WS-Management - Command line Utility | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | srinivas <srinivas_ramanatha> |
| Component: | Package Review | Assignee: | Matt Domsch <matt_domsch> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | a.badger, fedora-package-review, matt_domsch, notting, praveen_paladugu, vcrhonek, wwlinuxengineering |
| Target Milestone: | --- | Flags: | matt_domsch:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-14 06:27:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 458012 | ||
| Bug Blocks: | 468400 | ||
|
Description
srinivas
2008-08-06 06:59:51 UTC
Initial Review: rpmlint o/p: [root@localhost redhat]# rpmlint SRPMS/wsmancli-2.1.0-1.fc9.src.rpm [root@localhost redhat]# rpmlint RPMS/x86_64/wsmancli-* naming: ok spec file name matches: ok license = BSD: ok license tag: ok spec in english: ok spec legible: ok complies on i386 and x86_64: ok all BRs correct: ok spec doesn't use locales: ok properly uses ldconfig in scriptlets: ok not relocatable: ok dir ownership: ok no duplicate files: ok file perms correct: ok %clean section: ok consistent use of macros: ok code, not content: ok no large docs, no need for -doc subpackage: ok %doc usage ok headers in -devel: ok no static libs: ok no pkgconfig files: ok .so in -devel: ok all libtool .la files removed: ok no GUI, no .desktop files: ok dir ownership correct: ok %install does rm: ok filenames UTF8: ok Thanks Srinivas Agreed with the above review, this looks good. A few trivial fixups please, then I approve. You can make these changes at CVS checkin.
--- wsmancli.spec 2008-10-09 22:10:07.000000000 -0500
+++ wsmancli.spec.matt 2008-10-09 22:20:55.000000000 -0500
@@ -1,17 +1,17 @@
Name: wsmancli
-Version: 2.1.0
+Version: 2.1.0
Release: 1%{dist}
License: BSD
Url: http://www.openwsman.org/
Source: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.bz2
BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXXX)
-Group: System Environment/Daemons
-BuildRequires: openwsman-devel pkgconfig curl-devel
-Requires: openwsman curl
-Summary: Opensource Implementation of WS-Management-Command line Utility
+Group: Applications/System
+BuildRequires: openwsman-devel >= 2.1.0, pkgconfig curl-devel
+Summary: WS-Management Command Line Interface
%description
-Part of openwsman, an Opensource Implementation of WS-Management
+Command line interface for managing systems using the Web Services
+Management protocol.
%prep
%setup -q
Modified the spec file with the suggested changes. Thanks Srinivas New Package CVS Request ======================= Package Name: wsmancli Short Description:Command line interface for managing systems using the Web Services Management protocol Owners: srini Branches: F-8 F-9 EL-4 EL-5 InitialCC:mdomsch cvs done. srini - this needs to be rebuilt in the Fedora and EL branches now. Previous build requests failed as openwsman wasn't in the buildroots yet when you last tried to build. This is fixed for F-11, at least. Should this be closed? New Package CVS Request ======================= Package Name: wsmancli Short Description:Command line interface for managing systems using the Web Services Management protocol Owners: srini Branches: F-10 F-11 EPEL-4 EPEL-5 InitialCC:mdomsch This already appears to be done. What changes did you want to make here? Feel free to make a new request and set the flag if you have any changes to make. Was under the impression that EPEL-4 and EPEL-5 are different from EL-4 and EL-5. Currently everything is in place. Thank you Praveen |