Spec URL: http://linux.dell.com/files/fedora/openwsman/openwsman.spec SRPM URL: http://linux.dell.com/files/fedora/openwsman/ SRPM: openwsman-2.0.0-1.src.rpm Description: Hello, I have finished packaging up openwsman, and I would appreciate a review so that I can get it to Fedora Extras. Openwsman is a project intended to provide an open-source implementation of the Web Services Management specification (WS-Management) and to expose system management information on the Linux operating system using the WS-Management protocol. WS-Management is based on a suite of web services specifications and usage requirements that exposes a set of operations focused on and covers all system management aspects.
Adding NEEDSPONSOR (as the account "srini" in the account system does not have packager access) and fixing up dependencies.
I'll sponsor, he's one of my teammates.
I sponsored him.
Were you going to do the package review as well?
sure, I'll do the review, but he's got 3 packages in queue, and I'm working with him on the first one; once he's got that one nailed (and it's pretty close now), we'll work through the other two.
Updated to version 2.1.0 for security fixes, might as well start out with the most recent available from upstream. http://linux.dell.com/files/fedora/openwsman/matt/ Because I basically rewrote the whole spec file from scratch (the one included in upstream needed a lot of work), Srinivas is going to do the formal review on this one, then take over as the package owner going forward.
Here's the initial review: [root@localhost redhat]# rpmlint SRPMS/openwsman-2.1.0-1.fc9.src.rpm [root@localhost redhat]# rpmlint RPMS/x86_64/openwsman-* openwsman-devel.x86_64: W: dangling-relative-symlink /usr/lib64/openwsman/plugins/libwsman_identify_plugin.so libwsman_identify_plugin.so.1.0.0 openwsman-devel.x86_64: W: dangling-relative-symlink /usr/lib64/openwsman/plugins/libwsman_cim_plugin.so libwsman_cim_plugin.so.1.0.0 openwsman-devel.x86_64: W: dangling-relative-symlink /usr/lib64/openwsman/plugins/libwsman_test.so libwsman_test.so.1.0.0 openwsman-devel.x86_64: W: dangling-relative-symlink /usr/lib64/openwsman/authenticators/libwsman_pam_auth.so libwsman_pam_auth.so.1.0.0 openwsman-devel.x86_64: W: dangling-relative-symlink /usr/lib64/openwsman/authenticators/libwsman_file_auth.so libwsman_file_auth.so.1.0.0 openwsman-devel.x86_64: E: only-non-binary-in-usr-lib naming: ok spec file name matches: ok license = EPL: ok license tag: ok spec in english: ok spec legible: ok complies on i386 and x86_64: ok all BRs correct: ok spec doesn't use locales: ok properly uses ldconfig in scriptlets: ok not relocatable: ok dir ownership: ok no duplicate files: ok file perms correct: ok %clean section: ok consistent use of macros: ok code, not content: ok no large docs, no need for -doc subpackage: ok %doc usage ok headers in -devel: ok no static libs: ok no pkgconfig files: ok .so in -devel: ok all libtool .la files removed: ok no GUI, no .desktop files: ok dir ownership correct: ok %install does rm: ok filenames UTF8: ok Thanks Srinivas
Hello, One of the rpmlint warnings: "openwsman-devel.x86_64: W: dangling-relative-symlink /usr/lib64/openwsman/plugins/libwsman_identify_plugin.so libwsman_identify_plugin.so.1.0.0" is a rpm bug.(https://bugzilla.redhat.com/show_bug.cgi?id=189928) I would be fixing the rpmlint error soon and would be updating the rpmlint output. Thanks Srinivas.
I think the dangling symlinks can be ignored. Install the openwsman package, and then run rpmlint against the -devel package, and there shouldn't be any dangling symlinks seen then.
Thanks for the review. As everything is OK, and since we've flip-flopped back and forth between packager and reviewer here (it's a good learning experience to do so), I'll call it APPROVED. You're good to go for CVS branches. Please also request branches for EL-4 and -5.
New Package CVS Request ======================= Package Name: openwsman Short Description:Openwsman is a project intended to provide an open-source implementation of the Web Services Management specification (WS-Management) and to expose system management information on the Linux operating system using the WS-Management protocol. WS-Management is based on a suite of web services specifications and usage requirements that exposes a set of operations focused on and covers all system management aspects. Owners: srini Branches: F-8 F-9 EL-4 EL-5 InitialCC:mdomsch
Short description here should be a _very_ short description... Typically thats taken from the spec files Summary line. Can you shorten your request to just a short sentence for Short Description?
New Package CVS Request ======================= Package Name: openwsman Short Description:Web Services Management libraries Owners: srini Branches: F-8 F-9 EL-4 EL-5 InitialCC:mdomsch
cvs done
This appears to be built.
New Package CVS Request ======================= Package Name: openwsman Short Description:Web Services Management libraries Owners: srini Branches: F-10 F-11 EPEL-4 EPEL-5 InitialCC:mdomsch
This package already has all those branches. Feel free to add a new request and reset the flag if you need any further changes.
New Package CVS Request ======================= Package Name: openwsman Short Description:Web Services Management libraries Owners: srini praveenp Branches: F-12 InitialCC:mdomsch
cvs done.