Bug 458761

Summary: kernel: dlm: dlm/user.c input validation fixes [rhel-4.7.z]
Product: [Retired] Red Hat Cluster Suite Reporter: Eugene Teo (Security Response) <eteo>
Component: dlm-kernelAssignee: David Teigland <teigland>
Status: CLOSED DUPLICATE QA Contact: Cluster QE <mspqa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 4CC: ccaulfie, cfeist, cluster-maint, dhoward, edamato, eteo, kanderso, lwang, vmayatsk
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-08-27 19:57:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 458758    
Bug Blocks:    
Attachments:
Description Flags
patch to try none

Description Eugene Teo (Security Response) 2008-08-12 04:30:07 UTC 
+++ This bug was initially created as a clone of Bug #458758 +++

Description of problem:
a) in device_write(): add sentinel NUL byte, making sure that lspace.name will be NUL-terminated
b) in compat_input() be keep it simple about the amounts of data we are copying.

--- Additional comment from eteo on 2008-08-12 00:19:34 EDT ---

Proposed upstream patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=cb79f1998d89821a4dbac47f59a46ee3fbbf3c61

--- Additional comment from eteo on 2008-08-12 00:20:32 EDT ---

Created an attachment (id=314043)
Upstream patch for this issue
Comment 2 Kiersten (Kerri) Anderson 2008-08-12 14:40:59 UTC 
DLM is not part of the core kernel in rhel 4 and is provided as part of the cluster products so changing product name .z flags.
Comment 3 Eugene Teo (Security Response) 2008-08-12 15:11:51 UTC 
The code in rhel-4's version of dlm is quite different from rhel-5. I am not
sure if the changes in device_write (dlm_write in this version) needs the
change. Please verify. Thanks.
Comment 4 David Teigland 2008-08-13 19:26:31 UTC 
Created attachment 314241 [details]
patch to try

Here's a patch, but I don't have a way to test it.
Comment 5 Christine Caulfield 2008-08-14 08:37:46 UTC 
I've briefly tested that patch and it works for me. It also looks pretty benign.
Comment 6 David Teigland 2008-08-19 17:27:54 UTC 
commit in RHEL4 branch a479ddb2fa97033ce44ce11ae28925c55b176a55
commit in RHEL47 branch d8417ee4673aa8c07f9d314704000e248081416b
Comment 7 Chris Feist 2008-08-27 19:57:14 UTC 
Removing flags and marking as a duplicate of the official 4.7.z bug.

*** This bug has been marked as a duplicate of bug 460369 ***