Bug 459451

Summary: Changes in glyph point settings window could not be applied.
Product: [Fedora] Fedora Reporter: Caius Chance <K9>
Component: fontforgeAssignee: Kevin Fenzi <kevin>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 9CC: fonts-bugs, gaburici, i18n-bugs, petersen, roozbeh
Target Milestone: ---Keywords: i18n
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-12-16 23:18:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 458592    
Attachments:
Description Flags
Patch from George Williams none

Description Caius Chance 2008-08-19 01:32:26 UTC 
Description of problem:
There is a problem when changing setting through glyph point settings window. All the changes are not applied.

Version-Release number of selected component (if applicable):
fontforge-20080429-1

How reproducible:
Always

Steps to Reproduce:
1. Open Liberation Fonts 1.04 file LiberationSans-Regular.sfd with fontforge.
2. Double click on 'y' (U+0079) glyph to open edit window.
3. Right click filled dots in the centre junction of strokes and select Get Info.
4. On Location tab, change Normal to Interpolated.
5. Click OK button.
  
Actual results:
The glyph point is still filled dot which means still Normal.

Expected results:
The glyph point is changed to hollow dot which means interpolated.


Additional info:
Liberation Fonts 1.04 is available at: https://fedorahosted.org/liberation-fonts/export/b2fa06aa4d23caecaac324e6e09317a4bbdf82f0/tags/liberation-fonts-1.04/src/LiberationSans-Regular.sfd
Comment 1 Caius Chance 2008-08-19 01:57:46 UTC 
Reported bug to upstream mailing lists.
Comment 2 Caius Chance 2008-08-21 04:57:02 UTC 
Created attachment 314682 [details]
Patch from George Williams

George Williams (gww AT silcom DOT com) is one of contributors in fontforge-devel mailing lists.
Comment 3 Kevin Fenzi 2008-08-22 23:54:07 UTC 
excellent. :) 

Whats the impact here? Should we apply this patch now? Or wait for a new upstream release? 

Thoughts?
Comment 4 Caius Chance 2008-08-25 05:13:21 UTC 
Hi Kevin,

I have just tested this patch when I patched on bug #458592 and this patch resolves the problem. I support the application of this patch.

Unsure if his patch is accepted to be included in next upstream release yet.

Cheers, Caio.
Comment 5 Jens Petersen 2008-08-25 06:13:53 UTC 
http://sourceforge.net/mailarchive/message.php?msg_name=10614175.91219110957804.JavaMail.cchance%40sashimi.bne.redhat.com
Comment 6 Kevin Fenzi 2008-09-03 20:18:40 UTC 
Happily, this patch seems to be already applied in the latest upstream version which I have just built in rawhide. ;) 

Did you need this update in f9 as well? We try and not update fontforge in stable releases because fonts might also then need updating, leading to a lot of churn and problem. ;(
Comment 7 Caius Chance 2008-09-05 01:11:13 UTC 
IMHO, since F10 is due very soon, you don't need to update in f9. :)
Comment 8 Tony Fu 2008-09-10 03:12:46 UTC 
requested by Jens Petersen (#27995)
Comment 9 Kevin Fenzi 2008-12-02 06:36:05 UTC 
Can you confirm that this is now fixed in f10?
Comment 10 Kevin Fenzi 2008-12-16 23:18:59 UTC 
This seems already applied upstream, I am gonna go ahead and close this now. 

If you spot any problems with it, feel free to reopen or file a new bug.