Bug 460111
| Summary: | Review Request: perl-Data-ICal - Generates iCalendar (RFC 2445) calendar files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralf Corsepius <rc040203> |
| Component: | Package Review | Assignee: | Dan Horák <dan> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, xavier |
| Target Milestone: | --- | Flags: | dan:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-09-14 06:47:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 460107 | ||
| Bug Blocks: | 459536 | ||
|
Description
Ralf Corsepius
2008-08-26 08:48:23 UTC
formal review: OK source files match upstream: 7c9c01a3aa26eaa76eb6224d84349ffe66068f21 Data-ICal-0.13.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible. License text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. N/A compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). N/A debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. OK %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. this package is APPROVED New Package CVS Request ======================= Package Name: perl-Data-ICal Short Description: Generates iCalendar (RFC 2445) calendar files Owners: corsepiu Branches: F-8 F-9 InitialCC: perl-sig Thanks for the reviews, Dan. Your help is very much appreciated. Hopefully I have reviewed all the prerequisites for the new RT :-) Could you take a look at https://bugzilla.redhat.com/show_bug.cgi?id=452354 ? cvs done. perl-Data-ICal-0.13-3.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/perl-Data-ICal-0.13-3.fc8 perl-Data-ICal-0.13-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. perl-Data-ICal-0.13-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. As discussed with Ralf, I'll maintain the EL branches. Package Change Request ====================== Package Name: perl-Data-ICal New Branches: EL-4 EL-5 Owners: xavierb cvs done. |