Bug 460253

Summary: Review Request: qle - A QSO Logger and log Editor
Product: [Fedora] Fedora Reporter: Lucian Langa <lucilanga>
Component: Package ReviewAssignee: Jason Tibbitts <j>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, vanmeeuwen+fedora
Target Milestone: ---Flags: j: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-11-23 19:23:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lucian Langa 2008-08-27 05:17:32 UTC 
Spec URL: http://lucilanga.fedorapeople.org/qle.spec
SRPM URL: http://lucilanga.fedorapeople.org/qle-0.0.10-1.fc9.src.rpm
Description: The qle-package is a graphic QSO log viewer, log editor and QSO logger for amateur radio operators.

'qle' stands  for QSO Logger and  Editor. It is a  Perl/Tk script that
logs (or modifies)  QSOs directly  in a  fast and  light-weight SQLite
database.

Intended use: casual logging of  rag-chew and contest QSOs. The logger
caters for CW operators.

Table  headings, fonts,  colours and  other  attributes are  set in  a
user-editable configuration  file. The SQLite log  schema supplied may
be  altered to  suit your  taste, provided  the configuration  file is
updated accordingly.
Comment 1 Lucian Langa 2008-08-28 05:15:31 UTC 
.. added missing desktop file and bumped version

http://lucilanga.fedorapeople.org/qle-0.0.10-2.fc9.src.rpm
http://lucilanga.fedorapeople.org/qle.spec
Comment 2 Jason Tibbitts 2008-11-20 19:50:52 UTC 
This one builds, and is rather simple.

I guess it might be nice to define QSO somewhere in your %description.  I guess it makes sense to those who already know what it means, but it means nothing to me.

This package should own /etc/qle

* source files match upstream.  sha256sum:
   2e948b64233ded37b80a3e77009f1006bce40428f857a01792f3dd2385a7edb3  
   qle-0.0.10.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK (maybe define QSO)
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   config(qle) = 0.0.10-2.fc10
   qle = 0.0.10-2.fc10
  =
   /bin/bash
   /usr/bin/perl
   config(qle) = 0.0.10-2.fc10
   cwdaemon
   hamlib-perl
   perl
   perl(Config::General)
   perl(DBD::SQLite)
   perl(DBI)
   perl(English)
   perl(File::Basename)
   perl(IO::Socket)
   perl(Tk)
   perl(Tk::After)
   perl(Tk::Bitmap)
   perl(Tk::ErrorDialog)
   perl(Tk::ItemStyle)
   perl(strict)
   perl(warnings)

* %check is not present; no test suite upstream.  It seems to work when I run 
   it, although I've no idea how to do anything.
X fails to own /erc/qle
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* desktop files valid and installed properly.
Comment 3 Lucian Langa 2008-11-20 20:32:59 UTC 
> I guess it might be nice to define QSO somewhere in your %description.  I guess
> it makes sense to those who already know what it means, but it means nothing to
> me.

> 
> This package should own /etc/qle

Updated both:

http://lucilanga.fedorapeople.org/qle.spec
http://lucilanga.fedorapeople.org/qle-0.0.10-3.fc10.src.rpm
Comment 4 Jason Tibbitts 2008-11-20 21:02:45 UTC 
Looks good; thanks.

APPROVED
Comment 5 Lucian Langa 2008-11-21 05:47:09 UTC 
New Package CVS Request
=======================
Package Name: qle
Short Description: A QSO Logger and log Editor
Owners: lucilanga
Branches: F-8 F-9 devel EL-5 
InitialCC:
Cvsextras Commits: yes
Comment 6 Kevin Fenzi 2008-11-23 04:32:25 UTC 
cvs done.
Comment 7 Fedora Update System 2008-11-23 19:21:09 UTC 
qle-0.0.10-5.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/qle-0.0.10-5.fc8
Comment 8 Fedora Update System 2008-11-23 19:22:00 UTC 
qle-0.0.10-5.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/qle-0.0.10-5.fc9
Comment 9 Fedora Update System 2008-11-23 19:23:11 UTC 
qle-0.0.10-5.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/qle-0.0.10-5.fc10
Comment 10 Fedora Update System 2008-12-13 14:55:44 UTC 
qle-0.0.10-5.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 11 Fedora Update System 2008-12-13 14:57:17 UTC 
qle-0.0.10-5.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 12 Fedora Update System 2008-12-13 15:03:29 UTC 
qle-0.0.10-5.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.