Bug 460387
| Summary: | Review Request: python-schedutils - bindings for the scheduler settings interface | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Arnaldo Carvalho de Melo <acme> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-09-30 19:23:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Arnaldo Carvalho de Melo
2008-08-27 23:16:42 UTC
Suggestions:-
1)Where is upstream? I don't see URL tag in spec file. Add URL.
2) your build and install section for python package should look like this
%build
%{__python} setup.py build
%install
rm -rf $RPM_BUILD_ROOT
%{__python} setup.py install --skip-build --root $RPM_BUILD_ROOT
See http://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_using_Setuptools
4) preserve timestamps while using cp and install commands with -p option
5) conditional if is not needed F9>= releases
%if "%{python_ver}" >= "2.5"
%{python_sitearch}/*.egg-info
%endif
remove it and add only egginfo file.
I'm upstream, and I haven't setup a webpage for this package. I don't think it is required, but I'll probably will create a page at fedorahosted. Fixed #2 and #4 (where is #3? :) ) Is #5 strictly required? I'd love to have just one specfile to use in Fedora and older releases, for such a small specfile I guess the "ifdef hell" is not so painful? New specfile and .src.rpm at: http://userweb.kernel.org/~acme/python-schedutils/python-schedutils.spec http://userweb.kernel.org/~acme/python-schedutils/python-schedutils-0.2-2.fc10.src.rpm Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=792532 + rpmlint is silent for SRPM and for RPM. - source file md5 checksum from SRPM is 2e94101218ac254974d836b82a476b64 python-schedutils-0.2.tar.bz2 from upstream is de268b04b767df4214f61c72fac51007 python-schedutils-0.2.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. + Package python-schedutils-0.2-2.fc10 => Provides: schedutils.so Requires: /usr/bin/python libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libpthread.so.0 libpython2.5.so.1.0 python(abi) = 2.5 rtld(GNU_HASH) Suggestions: 1)from review guidelines - MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. ==> Resubmit SRPM with same tarball inside SRPM and upstream source URL in SPEC. 2) Not mandatory but you can use defattr as %defattr(-,root,root,-) Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=800407 New .src.rpm & upstream tarball: http://userweb.kernel.org/~acme/python-schedutils/python-schedutils-0.2-2.fc10.src.rpm http://userweb.kernel.org/~acme/python-schedutils/python-schedutils-0.2.tar.bz2 1)koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=805484 2)checksum of source tarball verified as 32623c3bafa8322d6d697dc1248aed1c python-schedutils-0.2.tar.bz2 APPROVED. acme ping pong: I'll try to continue the process today for this one and for python-ethtool Package Name: python-schedutils Short Description: Linux scheduler python bindings Owners: acme Branches: F-10 InitialCC: cvs done. |