Bug 460437

Summary:	system-config-samba dies with misleading message when pdbedit can't contact LDAP server
Product:	[Fedora] Fedora	Reporter:	Nils Philippsen <nphilipp>
Component:	system-config-samba	Assignee:	Nils Philippsen <nphilipp>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	nphilipp
Target Milestone:	---	Keywords:	FutureFeature, Reopened
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-11 11:23:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	460431

Description Nils Philippsen 2008-08-28 10:03:29 UTC

+++ This bug was initially created as a clone of Bug #460431 +++

Description of problem:
When samba is configured to use LDAP for storing account information and the LDAP server is not available (or some other error occures), system-config-samba dies with traceback.

Version-Release number of selected component (if applicable):
system-config-samba-1.2.41-3.el5.noarch

How reproducible:
always

Steps to Reproduce:
1. set "passdb backend" to "ldapsam:ldap://hostname-without-working-ldap-server"
2. run system-config-samba and wait for pdbedit to timeout

  
Actual results:
raceback (most recent call last):
  File "/usr/share/system-config-samba/system-config-samba.py", line 41, in ?
    mainWindow.MainWindow(debug_flag)
  File "/usr/share/system-config-samba/mainWindow.py", line 86, in __init__
    self.samba_user_data = sambaUserData.SambaUserData(self)
  File "/usr/share/system-config-samba/sambaUserData.py", line 42, in __init__
    self.readSmbPasswords()
  File "/usr/share/system-config-samba/sambaUserData.py", line 59, in readSmbPasswords
    raise RuntimeError, (_("You do not have permission to execute %s." % pdbeditcmd))
RuntimeError: You do not have permission to execute /usr/bin/pdbedit.


Expected results:
Sane error message telling what really has happened.

Additional info:

Comment 1 Nils Philippsen 2008-08-28 10:10:01 UTC

Added code to the upstream repo which at least dumps the pdbedit error messages if pdbedit fails and the user is root.

Comment 2 Nils Philippsen 2008-10-28 10:00:10 UTC

Should be fixed in 1.2.65 which is building right now.

Comment 3 Nils Philippsen 2013-04-15 11:54:41 UTC

Reopening to add the GUI side (which will be a bit involved due to the exceptions happening on the other side of the system bus).

Comment 4 Nils Philippsen 2013-04-15 13:47:47 UTC

commit fd93b4f559128397ca3b12cc109c49ece681a60d
Author:     Nils Philippsen <nils>
AuthorDate: Mon Apr 15 15:20:31 2013 +0200
Commit:     Nils Philippsen <nils>
CommitDate: Mon Apr 15 15:44:39 2013 +0200

    display runtime errors/exceptions in a dialog
    
    This is an improvement but doesn't quite fix #460437.

Comment 5 Nils Philippsen 2016-08-11 11:23:54 UTC

Thanks for taking the time to submit this request for enhancement.
Unfortunately, I haven't gotten around to implement this feature, sorry for
that.

Because I don't actively develop system-config-samba anymore, I won't likely
find the time to work on this ticket, so I'll close this bug now.