Bug 460615
| Summary: | Review Request: bti - Bash Twitter Idiocy | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lemenkov, notting |
| Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-09-25 00:14:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michel Lind
2008-08-29 02:59:27 UTC
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=792275 I'll review it. REVIEW:
+ rpmlint is silent.
+ The package is named according to the Package Naming Guidelines.
+ The spec file matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines .
+ The License field in the package spec file matches the actual license.
+ The text of the license(s) is included in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as provided in the spec URL.
[petro@Sulaco SOURCES]$ md5sum bti-005.tar.bz2*
65466367d82bae9b470bcf6591bdf37f bti-005.tar.bz2
65466367d82bae9b470bcf6591bdf37f bti-005.tar.bz2.orig
[petro@Sulaco SOURCES]$
+ The package successfully compiles and builds into binary rpms on at least one supported architecture (ppc).
+ All build dependencies are listed in BuildRequires.
+ The package does not contain any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.
+ The package consistently uses macros, as described in the macros section of Packaging Guidelines .
+ The package contains code, or permissable content.
+ Everything, the package includes as %doc, does not affect the runtime of the application.
+ The package does not own files or directories already owned by other packages.
+ At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT.
+ All filenames in rpm package are valid UTF-8.
APPROVED.
Thanks! New Package CVS Request ======================= Package Name: bti Short Description: Bash Twitter Idiocy Owners: salimma Branches: EL-5 F-8 F-9 InitialCC: cvs done. bti-005-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/bti-005-1.fc9 bti-005-1.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/bti-005-1.fc8 bti-005-1.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bti'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-7252 bti-005-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bti'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-7516 bti-005-1.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bti'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-7252 bti-005-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. bti-005-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: bti New Branches: epel7 Owners: salimma Git done (by process-git-requests). |