Bug 460912
| Summary: | Review Request: DeviceKit-power - Power Management Service | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard Hughes <rhughes> |
| Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bnocera, davidz, fedora-package-review, mclasen, notting, pahan |
| Target Milestone: | --- | Flags: | mclasen:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-10-02 13:06:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Richard Hughes
2008-09-02 16:04:00 UTC
[hughsie@hughsie-work RPMS]$ rpmlint DeviceKit-power-001-1.fc9.i386.rpm DeviceKit-power.i386: W: non-conffile-in-etc /etc/udev/rules.d/95-devkit-power-csr.rules DeviceKit-power.i386: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.DeviceKit.Power.conf DeviceKit-power.i386: W: non-conffile-in-etc /etc/udev/rules.d/95-devkit-power-wup.rules DeviceKit-power.i386: W: non-conffile-in-etc /etc/udev/rules.d/95-devkit-power-hid.rules 1 packages and 0 specfiles checked; 0 errors, 4 warnings. [hughsie@hughsie-work RPMS]$ rpmlint DeviceKit-power-devel-001-1.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [hughsie@hughsie-work RPMS]$ rpmlint ../SRPMS/DeviceKit-power-001-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. When upstream depends on a new udev, I'll install the rules files out of /etc -- but for now I want to build on F9 with a minimum of hassle. Branches required are F-10 (if we create after the branch) and devel. Taking this... Builds fine in mock. rpmlint says: [mclasen@localhost ~]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/DeviceKit-power-*.rpm DeviceKit-power.i386: W: non-conffile-in-etc /etc/udev/rules.d/95-devkit-power-csr.rules DeviceKit-power.i386: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.DeviceKit.Power.conf DeviceKit-power.i386: W: non-conffile-in-etc /etc/udev/rules.d/95-devkit-power-wup.rules DeviceKit-power.i386: W: non-conffile-in-etc /etc/udev/rules.d/95-devkit-power-hid.rules 4 packages and 0 specfiles checked; 0 errors, 4 warnings. All ignorable warnings package name: ok spec file name: ok packaging guidelines: ok license: ok license field: says MIT, but COPYING is GPL. What gives ? license: file: I notice the first line: Copyright (C) 2008 David Zeuthen <david> Maybe you want to add yourself there ? spec language: ok spec legibility: ok upstream sources: ok buildable: ok excludearch: n/a build deps: ok locale handling: n/a shared libs: ok relocatable: n/a directory ownership: ok duplicate files: ok file permissions: ok %clean: ok macro use: consistent content: permissable large docs: n/a header files: n/a static libs: n/a pc files: n/a versioned shared libs: n/a devel->base dep: ok libtool archives: ok gui apps: n/a directory ownership: must not own /usr/share/PolicyKit/policy (owned by PolicyKit) /usr/share/dbus-1/interfaces (owned by dbus) %install: ok utf8 filenames: ok In summary: - fix the license situation - fix directory ownership then its good to go Both issues fixed, I've added my copyright upstream and will be present in 002. Spec URL: http://people.freedesktop.org/~hughsient/fedora/DeviceKit-power.spec SRPM URL: http://people.freedesktop.org/~hughsient/fedora/DeviceKit-power-001-2.fc9.src.rpm Thanks. Looks fine now. Approved Your CVS request is missing info, see: http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure New Package CVS Request ======================= Package Name: DeviceKit-power Short Description: Power Management Service Owners: rhughes Branches: F-9 InitialCC: rhughes cvs done. Thanks Kevin. |