Bug 460912 - Review Request: DeviceKit-power - Power Management Service
Summary: Review Request: DeviceKit-power - Power Management Service
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-09-02 16:04 UTC by Richard Hughes
Modified: 2008-10-02 13:06 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-10-02 13:06:02 UTC
mclasen: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Richard Hughes 2008-09-02 16:04:00 UTC
Spec URL: http://people.freedesktop.org/~hughsient/fedora/DeviceKit-power.spec
SRPM URL: http://people.freedesktop.org/~hughsient/fedora/DeviceKit-power-001-1.fc9.src.rpm
Description: DeviceKit-power provides a daemon, API and command line tools for
managing power devices attached to the system. Along with the other DeviceKit-* daemons, it will replace most of the functionality of HAL in F11.

Comment 1 Richard Hughes 2008-09-02 16:05:47 UTC
[hughsie@hughsie-work RPMS]$ rpmlint DeviceKit-power-001-1.fc9.i386.rpm 
DeviceKit-power.i386: W: non-conffile-in-etc /etc/udev/rules.d/95-devkit-power-csr.rules
DeviceKit-power.i386: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.DeviceKit.Power.conf
DeviceKit-power.i386: W: non-conffile-in-etc /etc/udev/rules.d/95-devkit-power-wup.rules
DeviceKit-power.i386: W: non-conffile-in-etc /etc/udev/rules.d/95-devkit-power-hid.rules
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
[hughsie@hughsie-work RPMS]$ rpmlint DeviceKit-power-devel-001-1.fc9.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[hughsie@hughsie-work RPMS]$ rpmlint ../SRPMS/DeviceKit-power-001-1.fc9.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

When upstream depends on a new udev, I'll install the rules files out of /etc -- but for now I want to build on F9 with a minimum of hassle.

Comment 2 Richard Hughes 2008-09-02 16:08:27 UTC
Branches required are F-10 (if we create after the branch) and devel.

Comment 3 Matthias Clasen 2008-09-05 16:06:39 UTC
Taking this...

Comment 4 Matthias Clasen 2008-09-05 16:10:15 UTC
Builds fine in mock.
rpmlint says:

[mclasen@localhost ~]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/DeviceKit-power-*.rpm
DeviceKit-power.i386: W: non-conffile-in-etc /etc/udev/rules.d/95-devkit-power-csr.rules
DeviceKit-power.i386: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.DeviceKit.Power.conf
DeviceKit-power.i386: W: non-conffile-in-etc /etc/udev/rules.d/95-devkit-power-wup.rules
DeviceKit-power.i386: W: non-conffile-in-etc /etc/udev/rules.d/95-devkit-power-hid.rules
4 packages and 0 specfiles checked; 0 errors, 4 warnings.

All ignorable warnings

Comment 5 Matthias Clasen 2008-09-05 17:28:33 UTC

package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: says MIT, but COPYING is GPL. What gives ?
license: file: I notice the first line:

   Copyright (C) 2008 David Zeuthen <david@fubar.dk> 

   Maybe you want to add yourself there ?

spec language: ok
spec legibility: ok
upstream sources: ok
buildable: ok
excludearch: n/a
build deps: ok
locale handling: n/a
shared libs: ok
relocatable: n/a
directory ownership: ok
duplicate files: ok 
file permissions: ok
%clean: ok
macro use: consistent
content: permissable
large docs: n/a
header files: n/a
static libs: n/a
pc files: n/a
versioned shared libs: n/a
devel->base dep: ok
libtool archives: ok
gui apps: n/a
directory ownership: must not own
  /usr/share/PolicyKit/policy (owned by PolicyKit)
  /usr/share/dbus-1/interfaces (owned by dbus)
%install: ok
utf8 filenames: ok


In summary: 
 - fix the license situation
 - fix directory ownership

then its good to go

Comment 6 Richard Hughes 2008-09-06 10:24:01 UTC
Both issues fixed, I've added my copyright upstream and will be present in 002.

Spec URL: http://people.freedesktop.org/~hughsient/fedora/DeviceKit-power.spec
SRPM URL:
http://people.freedesktop.org/~hughsient/fedora/DeviceKit-power-001-2.fc9.src.rpm

Thanks.

Comment 7 Matthias Clasen 2008-09-06 17:44:37 UTC
Looks fine now. Approved

Comment 8 Bastien Nocera 2008-09-30 14:16:20 UTC
Your CVS request is missing info, see:
http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure

Comment 9 Richard Hughes 2008-09-30 15:43:47 UTC
New Package CVS Request
=======================
Package Name: DeviceKit-power
Short Description: Power Management Service
Owners: rhughes
Branches: F-9
InitialCC: rhughes

Comment 10 Kevin Fenzi 2008-10-01 19:06:00 UTC
cvs done.

Comment 11 Richard Hughes 2008-10-02 13:06:02 UTC
Thanks Kevin.


Note You need to log in before you can comment on or make changes to this bug.