Bug 461250 (justmoon-review)

Summary: Review-Request: justmoon - Just Moon is lunar observing software for Linux
Product: [Fedora] Fedora Reporter: Lubomir Rintel <lkundrak>
Component: Package ReviewAssignee: Marek Mahut <mmahut>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, mmahut, mtasaka, notting
Target Milestone: ---Flags: mmahut: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-09-12 05:47:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Lubomir Rintel 2008-09-05 11:14:56 UTC
SRPMS: http://netbsd.sk/~lkundrak/SRPMS/justmoon-0.3.3-1.el5.src.rpm
SPECS: http://netbsd.sk/~lkundrak/SPECS/justmoon.spec


This package contains a lunar observing software with
GTK+-based user interface that fits the GNOME Desktop environment,
and QT-based user interface that fits the KDE Desktop environment.
They are is supplemented with package that contains data files.

Comment 1 Marek Mahut 2008-09-05 12:30:02 UTC
[X]  RPMlink
  mixed-use-of-spaces-and-tabs - cosmetic issue
  rpm-buildroot-usage - please move desktop-file-install to %install
[OK] source files match upstream url
  3007c84e3b5232c0dba9f5c0b5c3a669 justmoon-0.3.3.tar.gz
[OK] package meets naming and packaging guideline
[OK] specfile is sane
[OK] spec file is legible
[OK] dist tag is present
[OK] build root is correct
[OK] license is Fedora compatible
[OK] %clean is present
[X] builds in rawhide


Comment 2 Lubomir Rintel 2008-09-05 12:59:15 UTC
Your internets is broken

Comment 4 Marek Mahut 2008-09-05 13:12:46 UTC
Please also correct the desktop file in %files, thanks.

Comment 5 Marek Mahut 2008-09-05 13:26:21 UTC
Great, looks correct! 

 - http://koji.fedoraproject.org/koji/taskinfo?taskID=808659

Comment 6 Lubomir Rintel 2008-09-05 13:29:36 UTC
Just in case anyone is interested what marek was reviewing (locally at FUDCon, since bugzilla was returning 500 errors).

SRPMS: http://netbsd.sk/~lkundrak/SRPMS/justmoon-0.3.3-3.el5.src.rpm
SPECS: http://netbsd.sk/~lkundrak/SPECS/justmoon.spec

New Package CVS Request
Package Name: justmoon
Short Description: Lunar observing software
Owners: lkundrak
Branches: F-8 F-9 EL-5

Comment 7 Kevin Fenzi 2008-09-05 13:36:28 UTC
cvs done.

Comment 8 Lubomir Rintel 2008-09-12 05:47:03 UTC
imported and built.