Bug 461250 - (justmoon-review) Review-Request: justmoon - Just Moon is lunar observing software for Linux
Review-Request: justmoon - Just Moon is lunar observing software for Linux
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Marek Mahut
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2008-09-05 07:14 EDT by Lubomir Rintel
Modified: 2008-09-12 01:47 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-09-12 01:47:03 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mmahut: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Lubomir Rintel 2008-09-05 07:14:56 EDT
SRPMS: http://netbsd.sk/~lkundrak/SRPMS/justmoon-0.3.3-1.el5.src.rpm
SPECS: http://netbsd.sk/~lkundrak/SPECS/justmoon.spec


This package contains a lunar observing software with
GTK+-based user interface that fits the GNOME Desktop environment,
and QT-based user interface that fits the KDE Desktop environment.
They are is supplemented with package that contains data files.
Comment 1 Marek Mahut 2008-09-05 08:30:02 EDT
[X]  RPMlink
  mixed-use-of-spaces-and-tabs - cosmetic issue
  rpm-buildroot-usage - please move desktop-file-install to %install
[OK] source files match upstream url
  3007c84e3b5232c0dba9f5c0b5c3a669 justmoon-0.3.3.tar.gz
[OK] package meets naming and packaging guideline
[OK] specfile is sane
[OK] spec file is legible
[OK] dist tag is present
[OK] build root is correct
[OK] license is Fedora compatible
[OK] %clean is present
[X] builds in rawhide

Comment 2 Lubomir Rintel 2008-09-05 08:59:15 EDT
Your internets is broken
Comment 4 Marek Mahut 2008-09-05 09:12:46 EDT
Please also correct the desktop file in %files, thanks.
Comment 5 Marek Mahut 2008-09-05 09:26:21 EDT
Great, looks correct! 

 - http://koji.fedoraproject.org/koji/taskinfo?taskID=808659
Comment 6 Lubomir Rintel 2008-09-05 09:29:36 EDT
Just in case anyone is interested what marek was reviewing (locally at FUDCon, since bugzilla was returning 500 errors).

SRPMS: http://netbsd.sk/~lkundrak/SRPMS/justmoon-0.3.3-3.el5.src.rpm
SPECS: http://netbsd.sk/~lkundrak/SPECS/justmoon.spec

New Package CVS Request
Package Name: justmoon
Short Description: Lunar observing software
Owners: lkundrak
Branches: F-8 F-9 EL-5
Comment 7 Kevin Fenzi 2008-09-05 09:36:28 EDT
cvs done.
Comment 8 Lubomir Rintel 2008-09-12 01:47:03 EDT
imported and built.

Note You need to log in before you can comment on or make changes to this bug.