Bug 461335
| Summary: | Review Request: csstidy - CSS parser and optimizer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ian Weller <ian> |
| Component: | Package Review | Assignee: | Rakesh Pandit <rpandit> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, huzaifas, notting |
| Target Milestone: | --- | Flags: | rpandit:
fedora-review+
huzaifas: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-09-13 03:56:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ian Weller
2008-09-06 00:25:24 UTC
Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=809955 completed successfully Build warning: **** Compiling in release mode... scons: warning: The env.Copy() method is deprecated; use the env.Clone() method instead. File "/home/rpmbuild/rpm/BUILD/csstidy-1.4/csstidy/SConscript", line 7, in <module> scons: done reading SConscript files. scons: Building targets ... you consider either using Clone method or use scons --warn=no-deprecated rpmlint clean rpmlint csstidy-1.4-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint csstidy-1.4-1.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint csstidy-debuginfo-1.4-1.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Will do a detailed review soon.
Summary:
APPROVED
1. You may like to fix above build WARNING.
Required:
[x] check the diff for src in srpm and source from project page
[x] license - correct
[x] license file - included
[x] naming - correct
[x] packaging guidelines correct
[x] doc files
[x] %file & %clean section have rm -rf %{buildroot}
[x] consistent use of macros
[x] license correct, version correct
[x] description and summary - ok
[x] spec file legible and uses American English
[x] compiles - okay
[x] BuildReauires and Requires - okay
[x] shared libs - NA , no duplicate files, header files NA, Static libs - NA
[x] owns all directories
Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated
Two more point, they are suggestions and don't block this request: 1. Remove this line: "# The developer is ridiculous and puts together this archive on Windows, and fails miserably. " It is not useful. 2. Regarding zip format: If even after requesting for uploading source in .tar.gz or bz2 format fails. You can also directly use zip format and no need to unzip and re-compress in .tar.gz Thanks (In reply to comment #4) > 2. Regarding zip format: > If even after requesting for uploading source in .tar.gz or bz2 format fails. > You can also directly use zip format and no need to unzip and re-compress in > .tar.gz > Actually, it is necessary. When unzipping, unzip returns warnings, which for some weird reason return 1, which stops rpmbuild. So, the options were to 1) rearchive it, or 2) create an ugly bash script to say that if it returns 1, it actually means zero. I'm lazy, so I selected number 1. Also the upstream developer sort of left the project, but the software is still useful nontheless. But anywho! New Package CVS Request ======================= Package Name: csstidy Short Description: CSS parser and optimizer Owners: ianweller Branches: F-8 F-9 EL-4 EL-5 InitialCC: cvs done csstidy-1.4-1.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/csstidy-1.4-1.fc8 csstidy-1.4-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/csstidy-1.4-1.fc9 csstidy-1.4-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. csstidy-1.4-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |