Bug 461388 (perl-Mouse)

Summary: Review Request: perl-Mouse - Moose minus the antlers
Product: [Fedora] Fedora Reporter: Chris Weyl <cweyl>
Component: Package ReviewAssignee: Jason Tibbitts <j>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, tremble
Target Milestone: ---Flags: j: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/dist/Mouse
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-10-07 02:57:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 461386    
Bug Blocks: 461383    

Description Chris Weyl 2008-09-07 04:34:16 UTC
SRPM URL: http://fedora.biggerontheinside.net/review/perl-Mouse-0.06-1.fc9.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-Mouse.spec

Description:
Moose is wonderful.

Unfortunately, it's a little slow. Though significant progress has been
made over the years, the compile time penalty is a non-starter for some
applications.  Mouse aims to alleviate this by providing a subset of Moose's
functionality, faster.

Comment 1 Jason Tibbitts 2008-09-07 16:59:40 UTC
Can't build this yet, but I note that the %description above is almost completely content-free if you don't know what Moose is.

Comment 2 Chris Weyl 2008-09-09 01:09:38 UTC
(In reply to comment #1)
> Can't build this yet, but I note that the %description above is almost
> completely content-free if you don't know what Moose is.

Just wait until they see Squirrel ;)  

How's this:

-----
Moose, a powerful metaobject-fuelled extension of the Perl 5 object system,
is wonderful.  (For more information on Moose, please see 'perldoc Moose'
after installing the perl-Moose package.)

Unfortunately, it's a little slow. Though significant progress has been
made over the years, the compile time penalty is a non-starter for some
applications.  Mouse aims to alleviate this by providing a subset of Moose's
functionality, faster.
-----

It builds on the first paragraph just a touch, and points people to the Moose manpage at least...

Comment 5 Jason Tibbitts 2008-10-03 16:32:15 UTC
I still don't understand how the Summary: helps to clarify much of anything, but upstream seems to prefer humor over useful documentation so what can we do?  Maybe consider "Lighter version of the Moose object system", but I don't think it should hold up approval of this package.

Otherwise everything looks fine to me.

* source files match upstream:
   e075052ab45008e512d78dd340ed62b55923a0faf124887088869b1ae5aa7eaa  
   Mouse-0.09.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Mouse) = 0.09
   perl(Mouse::Meta::Attribute)
   perl(Mouse::Meta::Class)
   perl(Mouse::Meta::Role)
   perl(Mouse::Object)
   perl(Mouse::Role)
   perl(Mouse::Tiny)
   perl(Mouse::TypeRegistry)
   perl(Mouse::Util)
   perl(Squirrel)
   perl(Squirrel::Role)
   perl-Mouse = 0.09-1.fc10
  =
   perl >= 0:5.006
   perl(:MODULE_COMPAT_5.10.0)
   perl(Carp)
   perl(Class::Method::Modifiers) >= 1.01
   perl(MRO::Compat) >= 0.09
   perl(Mouse::Meta::Attribute)
   perl(Mouse::Meta::Class)
   perl(Mouse::Meta::Role)
   perl(Mouse::Object)
   perl(Mouse::TypeRegistry)
   perl(Mouse::Util)
   perl(Scalar::Util) >= 1.19
   perl(Test::Exception) >= 0.27
   perl(base)
   perl(strict)
   perl(warnings)

* %check is present and all tests pass:
   All tests successful.
   Files=46, Tests=2160, 3 wallclock secs
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

Comment 6 Chris Weyl 2008-10-04 04:12:42 UTC
New Package CVS Request
=======================
Package Name: perl-Mouse
Short Description: Moose minus the antlers
Owners: cweyl
Branches: F-8, F-9, devel
InitialCC: perl-sig

Comment 7 Huzaifa S. Sidhpurwala 2008-10-06 09:40:41 UTC
cvs done

Comment 8 Chris Weyl 2008-10-07 02:57:38 UTC
Imported and built in devel.  Thanks for the review! :-)

Comment 9 Mark Chappell 2010-08-30 17:17:35 UTC
Package Change Request
======================
Package Name: perl-Mouse
New Branches: EL-6
Owners: tremble iarnell

cweyl has previously suggested that he's happy for others to maintain the EPEL branches

Comment 10 Kevin Fenzi 2010-08-30 17:23:04 UTC
Git done (by process-git-requests).