SRPM URL: http://fedora.biggerontheinside.net/review/perl-Mouse-0.06-1.fc9.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Mouse.spec Description: Moose is wonderful. Unfortunately, it's a little slow. Though significant progress has been made over the years, the compile time penalty is a non-starter for some applications. Mouse aims to alleviate this by providing a subset of Moose's functionality, faster.
Can't build this yet, but I note that the %description above is almost completely content-free if you don't know what Moose is.
(In reply to comment #1) > Can't build this yet, but I note that the %description above is almost > completely content-free if you don't know what Moose is. Just wait until they see Squirrel ;) How's this: ----- Moose, a powerful metaobject-fuelled extension of the Perl 5 object system, is wonderful. (For more information on Moose, please see 'perldoc Moose' after installing the perl-Moose package.) Unfortunately, it's a little slow. Though significant progress has been made over the years, the compile time penalty is a non-starter for some applications. Mouse aims to alleviate this by providing a subset of Moose's functionality, faster. ----- It builds on the first paragraph just a touch, and points people to the Moose manpage at least...
http://koji.fedoraproject.org/koji/taskinfo?taskID=816742
SRPM URL: http://fedora.biggerontheinside.net/review/perl-Mouse-0.09-1.fc9.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Mouse.spec Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=856180
I still don't understand how the Summary: helps to clarify much of anything, but upstream seems to prefer humor over useful documentation so what can we do? Maybe consider "Lighter version of the Moose object system", but I don't think it should hold up approval of this package. Otherwise everything looks fine to me. * source files match upstream: e075052ab45008e512d78dd340ed62b55923a0faf124887088869b1ae5aa7eaa Mouse-0.09.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(Mouse) = 0.09 perl(Mouse::Meta::Attribute) perl(Mouse::Meta::Class) perl(Mouse::Meta::Role) perl(Mouse::Object) perl(Mouse::Role) perl(Mouse::Tiny) perl(Mouse::TypeRegistry) perl(Mouse::Util) perl(Squirrel) perl(Squirrel::Role) perl-Mouse = 0.09-1.fc10 = perl >= 0:5.006 perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Class::Method::Modifiers) >= 1.01 perl(MRO::Compat) >= 0.09 perl(Mouse::Meta::Attribute) perl(Mouse::Meta::Class) perl(Mouse::Meta::Role) perl(Mouse::Object) perl(Mouse::TypeRegistry) perl(Mouse::Util) perl(Scalar::Util) >= 1.19 perl(Test::Exception) >= 0.27 perl(base) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=46, Tests=2160, 3 wallclock secs * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one.
New Package CVS Request ======================= Package Name: perl-Mouse Short Description: Moose minus the antlers Owners: cweyl Branches: F-8, F-9, devel InitialCC: perl-sig
cvs done
Imported and built in devel. Thanks for the review! :-)
Package Change Request ====================== Package Name: perl-Mouse New Branches: EL-6 Owners: tremble iarnell cweyl has previously suggested that he's happy for others to maintain the EPEL branches
Git done (by process-git-requests).