Bug 461404

Summary:	Review Request: beep - Beep the PC speaker any number of ways
Product:	[Fedora] Fedora	Reporter:	Hans Ulrich Niedermann <rhbugs>
Component:	Package Review	Assignee:	Jeroen van Meeuwen <vanmeeuwen+fedora>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	andreas, fedora-package-review, notting, vanmeeuwen+fedora
Target Milestone:	---	Flags:	vanmeeuwen+fedora: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-09-08 08:15:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Hans Ulrich Niedermann 2008-09-07 11:09:35 UTC

Spec URL: http://ndim.fedorapeople.org/packages/beep/1.2.2-3.fc9/beep.spec
SRPM URL: http://ndim.fedorapeople.org/packages/beep/1.2.2-3.fc9/beep-1.2.2-3.fc9.src.rpm
Description:

Beep allows the user to control the PC speaker with precision,
allowing different sounds to indicate different events. While it
can be run quite happily on the commandline, it's intended place
of residence is within shell/perl scripts, notifying the user when
something interesting occurs. Of course, it has no notion of
what's interesting, but it's real good at that notifying part.


Zero rpmlint output:
http://ndim.fedorapeople.org/packages/beep/1.2.2-3.fc9/rpmlint.txt

Shipped files:
http://ndim.fedorapeople.org/packages/beep/1.2.2-3.fc9/filelist.txt

Build log:
http://ndim.fedorapeople.org/packages/beep/1.2.2-3.fc9/build.log

Successful scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=811677

Comment 1 Fabian Affolter 2008-09-07 12:59:54 UTC

This is only an informal review.

RPM Lint:  ok
Package name:  ok
Spec file: ok
License:  ok
Actual License: ok
%doc License:  ok
Spec file language:  english
Spec file readable:  ok
Upstream source vs. used tarball:  ok
Compile and Build:
 - F-8: ok
 - F-9: ok
 - rawhide: ok
 - EL-5:  - 

Applicable Package Guidelines:  

Locales:  ok
Shared libs:  n/a

Relocatable:  n/a
Directory and file ownership:  ok
No duplicate files in %files:  ok
File Permissions:  ok
Macro usage:  ok
Code vs. Content:  ok
(Large) Documentation:  ok
%doc affecting runtime:  ok
Header files in -devel package:  ok
Static Libraries in -static package:  ok
pkgconfig Requires:  n/a
Library files:  n/a
Devel requires base package:  n/a
.la libtool archives:  n/a
Duplicate ownership of files/directories:  ok
Remove BuildRoot:  ok
UTF-8 filenames:  ok

Comment 2 Jeroen van Meeuwen 2008-09-07 14:14:46 UTC

Good review Fabian, thanks.

APPROVED

Comment 3 Hans Ulrich Niedermann 2008-09-07 14:23:32 UTC

New Package CVS Request
=======================
Package Name: beep
Short Description: Beep the PC speaker any number of ways
Owners: ndim
Branches: F-8 F-9

Comment 4 Kevin Fenzi 2008-09-08 04:13:19 UTC

cvs done.

Comment 5 Hans Ulrich Niedermann 2008-09-08 08:15:11 UTC

Thanks for reviewing and CVS. Updates are in testing.