Spec URL: http://ndim.fedorapeople.org/packages/beep/1.2.2-3.fc9/beep.spec SRPM URL: http://ndim.fedorapeople.org/packages/beep/1.2.2-3.fc9/beep-1.2.2-3.fc9.src.rpm Description: Beep allows the user to control the PC speaker with precision, allowing different sounds to indicate different events. While it can be run quite happily on the commandline, it's intended place of residence is within shell/perl scripts, notifying the user when something interesting occurs. Of course, it has no notion of what's interesting, but it's real good at that notifying part. Zero rpmlint output: http://ndim.fedorapeople.org/packages/beep/1.2.2-3.fc9/rpmlint.txt Shipped files: http://ndim.fedorapeople.org/packages/beep/1.2.2-3.fc9/filelist.txt Build log: http://ndim.fedorapeople.org/packages/beep/1.2.2-3.fc9/build.log Successful scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=811677
This is only an informal review. RPM Lint: ok Package name: ok Spec file: ok License: ok Actual License: ok %doc License: ok Spec file language: english Spec file readable: ok Upstream source vs. used tarball: ok Compile and Build: - F-8: ok - F-9: ok - rawhide: ok - EL-5: - Applicable Package Guidelines: Locales: ok Shared libs: n/a Relocatable: n/a Directory and file ownership: ok No duplicate files in %files: ok File Permissions: ok Macro usage: ok Code vs. Content: ok (Large) Documentation: ok %doc affecting runtime: ok Header files in -devel package: ok Static Libraries in -static package: ok pkgconfig Requires: n/a Library files: n/a Devel requires base package: n/a .la libtool archives: n/a Duplicate ownership of files/directories: ok Remove BuildRoot: ok UTF-8 filenames: ok
Good review Fabian, thanks. APPROVED
New Package CVS Request ======================= Package Name: beep Short Description: Beep the PC speaker any number of ways Owners: ndim Branches: F-8 F-9
cvs done.
Thanks for reviewing and CVS. Updates are in testing.