Bug 461818

Summary:	Review Request: gears-backgrounds - Gears desktop backgrounds
Product:	[Fedora] Fedora	Reporter:	Martin Sourada <martin.sourada>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, tcallawa
Target Milestone:	---	Flags:	tcallawa: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-09-11 00:03:43 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Sourada 2008-09-10 20:11:00 UTC

Spec URL: http://mso.fedorapeople.org/packages/SPECS/gears-backgrounds.spec
SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/gears-backgrounds-0.0.1-1.fc9.src.rpm
Description: This package contains desktop backgrounds for the Gears theme.

Part of F10 Round3 Themes submissions wallpapers package batch.

Comment 1 Tom "spot" Callaway 2008-09-10 21:17:37 UTC

REVIEW
=======
Bad:

- Don't use "%{_prefix}/share", use "%{_datadir}" (you got it right in the %files section)

Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (CC-BY-SA) OK, text in %doc, matches source
- spec file legible, in am. english
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- content, OK
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Should Fix:
- Source tarball has no upstream URL location. You should really make a home for it and reference the full URL in the spec.

Show me a fixed spec file with %{_datadir} used consistently and I'll approve.

Comment 2 Martin Sourada 2008-09-10 21:29:19 UTC

%{_datadir} issue fixed.

New SPEC: http://mso.fedorapeople.org/packages/SPECS/gears-backgrounds.spec

Comment 3 Tom "spot" Callaway 2008-09-10 21:36:01 UTC

APPROVED.

Comment 4 Martin Sourada 2008-09-10 21:45:12 UTC

New Package CVS Request
=======================
Package Name: gears-backgrounds
Short Description: Gears desktop backgrounds
Owners: mso
Branches: F-8 F-9
InitialCC:

Comment 5 Jason Tibbitts 2008-09-10 23:38:17 UTC

CVS done.