Spec URL: http://mso.fedorapeople.org/packages/SPECS/gears-backgrounds.spec SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/gears-backgrounds-0.0.1-1.fc9.src.rpm Description: This package contains desktop backgrounds for the Gears theme. Part of F10 Round3 Themes submissions wallpapers package batch.
REVIEW ======= Bad: - Don't use "%{_prefix}/share", use "%{_datadir}" (you got it right in the %files section) Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (CC-BY-SA) OK, text in %doc, matches source - spec file legible, in am. english - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - content, OK - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Should Fix: - Source tarball has no upstream URL location. You should really make a home for it and reference the full URL in the spec. Show me a fixed spec file with %{_datadir} used consistently and I'll approve.
%{_datadir} issue fixed. New SPEC: http://mso.fedorapeople.org/packages/SPECS/gears-backgrounds.spec
APPROVED.
New Package CVS Request ======================= Package Name: gears-backgrounds Short Description: Gears desktop backgrounds Owners: mso Branches: F-8 F-9 InitialCC:
CVS done.