Bug 461819

Summary: Review Request: invinxble-backgrounds - InvinXble desktop backgrounds
Product: [Fedora] Fedora Reporter: Martin Sourada <martin.sourada>
Component: Package ReviewAssignee: Tom "spot" Callaway <tcallawa>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, tcallawa
Target Milestone: ---Flags: tcallawa: fedora-review+
j: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-09-11 00:03:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Martin Sourada 2008-09-10 20:11:10 UTC
Spec URL: http://mso.fedorapeople.org/packages/SPECS/invinxble-backgrounds.spec
SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/invinxble-backgrounds-0.0.1-1.fc9.src.rpm
Description: This package contains desktop backgrounds for the InvinXble theme.

Part of F10 Round3 Themes submissions wallpapers package batch.

Comment 1 Martin Sourada 2008-09-10 21:29:40 UTC
%{_datadir} issue fixed.

New SPEC: http://mso.fedorapeople.org/packages/SPECS/invinxble-backgrounds.spec

Comment 2 Tom "spot" Callaway 2008-09-10 21:31:58 UTC
REVIEW (based on updated spec)
=======
Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (CC-BY-SA) OK, text in %doc, matches source
- spec file legible, in am. english
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- macro use consistent
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- content, OK
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Should Fix:
- Source tarball has no upstream URL location. You should really make a home
for it and reference the full URL in the spec.

APPROVED.

Comment 3 Martin Sourada 2008-09-10 21:45:15 UTC
New Package CVS Request
=======================
Package Name: invinxble-backgrounds
Short Description: InvinXble desktop backgrounds
Owners: mso
Branches: F-8 F-9
InitialCC:

Comment 4 Jason Tibbitts 2008-09-10 23:38:28 UTC
CVS done.