Bug 461819 - Review Request: invinxble-backgrounds - InvinXble desktop backgrounds
Review Request: invinxble-backgrounds - InvinXble desktop backgrounds
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Tom "spot" Callaway
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-10 16:11 EDT by Martin Sourada
Modified: 2008-09-10 20:03 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-09-10 20:03:46 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
tcallawa: fedora‑review+
tibbs: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Martin Sourada 2008-09-10 16:11:10 EDT
Spec URL: http://mso.fedorapeople.org/packages/SPECS/invinxble-backgrounds.spec
SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/invinxble-backgrounds-0.0.1-1.fc9.src.rpm
Description: This package contains desktop backgrounds for the InvinXble theme.

Part of F10 Round3 Themes submissions wallpapers package batch.
Comment 1 Martin Sourada 2008-09-10 17:29:40 EDT
%{_datadir} issue fixed.

New SPEC: http://mso.fedorapeople.org/packages/SPECS/invinxble-backgrounds.spec
Comment 2 Tom "spot" Callaway 2008-09-10 17:31:58 EDT
REVIEW (based on updated spec)
=======
Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (CC-BY-SA) OK, text in %doc, matches source
- spec file legible, in am. english
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- macro use consistent
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- content, OK
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Should Fix:
- Source tarball has no upstream URL location. You should really make a home
for it and reference the full URL in the spec.

APPROVED.
Comment 3 Martin Sourada 2008-09-10 17:45:15 EDT
New Package CVS Request
=======================
Package Name: invinxble-backgrounds
Short Description: InvinXble desktop backgrounds
Owners: mso
Branches: F-8 F-9
InitialCC:
Comment 4 Jason Tibbitts 2008-09-10 19:38:28 EDT
CVS done.

Note You need to log in before you can comment on or make changes to this bug.