Bug 463079
| Summary: | Review Request: ibp - A tool to show which IBP beacons are transmitting | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lucian Langa <lucilanga> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, vanmeeuwen+fedora |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-11-23 19:19:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Lucian Langa
2008-09-21 13:08:01 UTC
Not much to say about this one. * source files match upstream. sha256sum: b3b118ca83619f0a5605652a0a8c385c77ada3a10321a771e2d19f9f59604abd ibp-0.21.tgz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: ibp = 0.21-1.fc10 ibp(x86-64) = 0.21-1.fc10 = libX11.so.6()(64bit) libncurses.so.5()(64bit) libtinfo.so.5()(64bit) * %check is not present; seems to run OK although I've no idea how to interpret the output. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. * desktop files valid and installed properly. APPROVED New Package CVS Request ======================= Package Name: ibp Short Description: A tool to show which IBP beacons are transmitting Owners: lucilanga Branches: F-8 F-9 devel EL-5 InitialCC: Cvsextras Commits: yes cvs done (also with F-10 branch). ibp-0.21-2.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/ibp-0.21-2.fc8 ibp-0.21-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/ibp-0.21-1.fc9 ibp-0.21-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/ibp-0.21-1.fc10 ibp-0.21-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. ibp-0.21-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. ibp-0.21-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |