Bug 463226

Summary:	Review Request: ace - Appliance Configuration Engine
Product:	[Fedora] Fedora	Reporter:	Bryan Kearney <bkearney>
Component:	Package Review	Assignee:	David Lutterkort <lutter>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bkearney, fedora-package-review, hbrock, lutter, notting
Target Milestone:	---	Flags:	lutter: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-09-25 22:27:40 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Bryan Kearney 2008-09-22 16:53:14 UTC

Spec URL: http://bkearney.fedorapeople.org/ace.spec
SRPM URL: http://bkearney.fedorapeople.org/ace-0.0.3-2.fc9.src.rpm
Description: Appliance Configuration Engine which is part of the thincrust tooling. It provides boot time configuration of the appliance.

Comment 1 David Lutterkort 2008-09-23 19:02:18 UTC

  OK - Package name
  OK - License info is accurate
  OK - License tag is correct and licenses are approved
  OK - License files are installed as %doc
  OK - Specfile name
  OK - Specfile is legible
  OK - No prebuilt binaries included
  FIX - BuildRoot value (one of the recommended values)

  Use one of the values listed here: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

  OK - PreReq not used
  FIX - Source md5sum matches upstream

  tarball is not available upstream; since you are upstream, you should
  publish a tarball for every release

  FIX - No hardcoded pathnames

  instead of binHome, use %{_bindir}
  instead of initHome, use %{_initrddir}
  instead of /usr/share in aceHome use %{_datadir}
  would prefer macro 'rubySiteHome' is called 'ruby_sitelibdir' for conistency

  OK - Package owns all the files it installs
  OK - 'Requires' create needed unowned directories
  OK - Package builds successfully on i386 and x86_64 (mock)
  OK - BuildRequires sufficient
  OK - File permissions set properly
  FIX - Macro usage is consistent
  
  use install -p or cp -pr instead of %{__cp} -R

  OK - rpmlint is silent

Comment 2 Bill Nottingham 2008-09-23 20:17:17 UTC

chckonfig usage is completely broken. Please see examples @ http://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets

Comment 3 Bryan Kearney 2008-09-24 13:25:13 UTC

Thank you both for the comments. I have made the changes and uploaded the new files. 

Spec URL: http://bkearney.fedorapeople.org/ace.spec
SRPM URL: http://bkearney.fedorapeople.org/ace-0.0.3-3.fc9.src.rpm

rmlint clean
builds clean in koji for f9

Comment 4 Bryan Kearney 2008-10-02 19:08:28 UTC

Per a comment from Bill Nottingham, I have moved all ace-* modules into a subpackge. The chaneged srpm and spec file are below:


Spec URL: http://bkearney.fedorapeople.org/ace.spec
SRPM URL: http://bkearney.fedorapeople.org/ace-0.0.3-4.fc9.src.rpm


rpmlint is clean
builds in koji on f9:  http://koji.fedoraproject.org/koji/taskinfo?taskID=857555

Comment 5 David Lutterkort 2008-10-15 19:21:23 UTC

Looks good now

APPROVED

Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import
the package. Close this bug as RAWHIDE once it's been successfully imported
and built.

Comment 6 Bryan Kearney 2008-10-15 19:32:47 UTC

New Package CVS Request
=======================
Package Name: ace
Short Description: Appliance Configuration Engine
Owners: bkearney
Branches: F-9 F10
InitialCC: None

Comment 7 Kevin Fenzi 2008-10-15 21:53:27 UTC

cvs done.

Comment 8 David Lutterkort 2009-09-25 22:27:40 UTC

Closed, since it's been done for a while