Spec URL: http://bkearney.fedorapeople.org/ace.spec SRPM URL: http://bkearney.fedorapeople.org/ace-0.0.3-2.fc9.src.rpm Description: Appliance Configuration Engine which is part of the thincrust tooling. It provides boot time configuration of the appliance.
OK - Package name OK - License info is accurate OK - License tag is correct and licenses are approved OK - License files are installed as %doc OK - Specfile name OK - Specfile is legible OK - No prebuilt binaries included FIX - BuildRoot value (one of the recommended values) Use one of the values listed here: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag OK - PreReq not used FIX - Source md5sum matches upstream tarball is not available upstream; since you are upstream, you should publish a tarball for every release FIX - No hardcoded pathnames instead of binHome, use %{_bindir} instead of initHome, use %{_initrddir} instead of /usr/share in aceHome use %{_datadir} would prefer macro 'rubySiteHome' is called 'ruby_sitelibdir' for conistency OK - Package owns all the files it installs OK - 'Requires' create needed unowned directories OK - Package builds successfully on i386 and x86_64 (mock) OK - BuildRequires sufficient OK - File permissions set properly FIX - Macro usage is consistent use install -p or cp -pr instead of %{__cp} -R OK - rpmlint is silent
chckonfig usage is completely broken. Please see examples @ http://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets
Thank you both for the comments. I have made the changes and uploaded the new files. Spec URL: http://bkearney.fedorapeople.org/ace.spec SRPM URL: http://bkearney.fedorapeople.org/ace-0.0.3-3.fc9.src.rpm rmlint clean builds clean in koji for f9
Per a comment from Bill Nottingham, I have moved all ace-* modules into a subpackge. The chaneged srpm and spec file are below: Spec URL: http://bkearney.fedorapeople.org/ace.spec SRPM URL: http://bkearney.fedorapeople.org/ace-0.0.3-4.fc9.src.rpm rpmlint is clean builds in koji on f9: http://koji.fedoraproject.org/koji/taskinfo?taskID=857555
Looks good now APPROVED Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import the package. Close this bug as RAWHIDE once it's been successfully imported and built.
New Package CVS Request ======================= Package Name: ace Short Description: Appliance Configuration Engine Owners: bkearney Branches: F-9 F10 InitialCC: None
cvs done.
Closed, since it's been done for a while