Bug 463771
| Summary: | Package review: perl-Probe-Perl | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcela Mašláňová <mmaslano> |
| Component: | Package Review | Assignee: | Dan Horák <dan> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dan, fedora-package-review, notting, paul |
| Target Milestone: | --- | Flags: | dan:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-09-29 09:51:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 457517 | ||
|
Description
Marcela Mašláňová
2008-09-24 16:15:00 UTC
formal review is here, see the notes below: OK source files match upstream: 36a9dde1953c0ab0bcd3998fca876b8f20f245cd Probe-Perl-0.01.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible. License text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. N/A compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). N/A debuginfo package looks complete. OK rpmlint is silent. OK* final provides and requires look sane. OK %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - the explicit R: perl(Config) is redundant, it is found automagically this package is APPROVED I'll remove perl(Config) for CVS build. New Package CVS Request ======================= Package Name: perl-Probe-Perl Short Description: obtain information about perl interpreter Owners: mmaslano Branches: rawhide InitialCC: fedora-perl-devel-list cvs done. Marcela, could I please have an EPEL-5 branch for this package? New Package CVS Request ======================= Package Name: perl-Probe-Perl Short Description: obtain information about perl interpreter Owners: pghmcfc Branches: EL-5 InitialCC: perl-devel [Paul asked me for a new branch for EL-5.] Already exists, use a Package Change request to add a branch. And use perl-sig, not perl-devel. Package Change Request ====================== Package Name: perl-Probe-Perl New Branches: EL-5 Owners: pghmcfc InitialCC: perl-sig Git done (by process-git-requests). perl-Probe-Perl-0.01-4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Probe-Perl-0.01-4.el5 perl-Probe-Perl-0.01-4.el5 has been pushed to the Fedora EPEL 5 stable repository. |