The application maintains its configuration information in a directory called .padre http://mmaslano.fedorapeople.org/Padre/
I can't pass test and the same problem appears after installation. The application is running as I can say, but it should be removed before adding into Fedora.
Created attachment 313173 [details] Warning
Update to new version http://mmaslano.fedorapeople.org/Padre/perl-Padre-0.06-1.fc9.src.rpm
Same here. Spec file, description of package ? Thanks.
The spec http://mmaslano.fedorapeople.org/Padre/perl-Padre.spec Official description is quite short. Let's made up new one. Description: Padre is a text editor aimed to be an IDE for Perl. The application maintains its configuration information in a directory called .padre.
http://mmaslano.fedorapeople.org/Padre/perl-Padre.spec http://mmaslano.fedorapeople.org/Padre/perl-Padre-0.10-1.fc9.src.rpm
The tests should be switched off for inclusion, because it needs graphic. I've also problem with one test and I reported this into upstream.
This test should be ignored in the meantime, please review.
formal review is here, see the notes below: OK source files match upstream: d810f98c2b56bb54d89d1a41596d8fbddfdf699c Padre-0.10.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible. License text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. N/A compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). N/A debuginfo package looks complete. BAD rpmlint is silent. OK final provides and requires look sane. N/A* %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. BAD* doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. BAD is a GUI app, desktop file is missing - rpmlint complains perl-Padre.noarch: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Padre/Wx/Ack.pm remove the executable bits perl-Padre.noarch: E: non-executable-script /usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Padre/templates/template.pl 0644 perl-Padre.noarch: E: non-executable-script /usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Padre/templates/template.t 0644 when /auto/share/dist/Padre/templates/* must be packaged (it is required for Padre to work correctly), then you should package 2 dirs %{perl_vendorlib}/Padre + %{perl_vendorlib}/auto/share/dist/Padre, but not the whole %{perl_vendorlib}/* hierarchy - tests requires running X, so the check section is disabled, but the proper BR: can exist in the spec (commented out) - it is a GUI application, but desktop file is missing - when running Padre in mock/Rawhide I got an error "libwx_gtk2u_stc-2.8.so: cannot open shared object file: No such file or directory", window title "Padre::Wx::App Error" - looks like something wants to open development version of this library even when the runtime lib is installed
This example and test should have permission 644 /usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Padre/templates/template.pl /usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Padre/templates/template.pl Desktop file wasn't included in upstream source. Should I create it or file a bug to upstream? The error "libwx_gtk2u_stc-2.8.so:..." wasn't resolved by upstream till now, but he's working on solution. http://mmaslano.fedorapeople.org/Padre/perl-Padre.spec http://mmaslano.fedorapeople.org/Padre/perl-Padre-0.10-2.fc9.src.rpm
(In reply to comment #10) > This example and test should have permission 644 > /usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Padre/templates/template.pl > /usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Padre/templates/template.pl ok > > Desktop file wasn't included in upstream source. Should I create it or file a > bug to upstream? please create one - https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files > The error "libwx_gtk2u_stc-2.8.so:..." wasn't resolved by upstream till now, > but he's working on solution. ok
http://mmaslano.fedorapeople.org/Padre/perl-Padre.spec http://mmaslano.fedorapeople.org/Padre/perl-Padre-0.10-3.fc9.src.rpm
http://mmaslano.fedorapeople.org/Padre/perl-Padre.spec http://mmaslano.fedorapeople.org/Padre/perl-Padre-0.10-4.fc9.src.rpm
All issues fixed, package is APPROVED. But remove the "--add-category" parameter when calling desktop-file-install (category is already set in the dekstop file itself) before import.
New Package CVS Request ======================= Package Name: perl-Padre Short Description: text editor aimed to be an IDE for Perl Owners: mmaslano Branches: F-10 rawhide InitialCC: fedora-perl-devel-list
cvs done
Should be in F-10 perl-Padre-0.10-4.fc10.