Bug 464051 (projectM-jack)
| Summary: | Package Review Request for projectM-jack | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jameson <imntreal> |
| Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, oget.fedora |
| Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-11-19 14:51:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 464049 | ||
| Bug Blocks: | |||
|
Description
Jameson
2008-09-26 03:30:06 UTC
I have a new SPEC in original location, and a new SRPM: http://www.vtscrew.com/projectM-jack-1.2.0-2.fc9.src.rpm I have a new SPEC in original location, and a new SRPM: http://www.vtscrew.com/projectM-jack-1.2.0-3.fc9.src.rpm This one is almost perfect. There are few little things to go through. * URL has a typo * Same subtleties apply for the license of this package as for the projectM-pulseaudio. "GPLv2+ and MIT" is fine but it would be good if we get a confirmation from upstream. * I don't see any .la files built. You should remove that line. * For the desktop file, please add Encoding=UTF-8 Terminal=false You use the same icon in the desktop file that you use for projectM-pulseaudio. You can require projectM-pulseaudio on this package, but that's not a nice solution. I think the best solution is renaming the icon file for this package. I have a new SPEC in original location, and a new SRPM: http://www.vtscrew.com/projectM-jack-1.2.0-4.fc9.src.rpm I double checked the URL, and it worked for me. Am I still missing something in it? I'm still waiting to hear from upstream about the license issues. I'm afraid I've scared them off with it, though. Sorry, I forgot that la files line. I thought I got rid of all of them. The desktop file is updated. I didn't think I would need to require the pulseaudio package since the icon is actually installed with libprojectM-qt. Oh URL, not SOURCE. Gotcha My bad, I thought the icon belongs to projectM-pulseaudio. Then there is no problem with the icon. I will check this package probably tomorrow morning (EST). All good! ------------------------------------------------ This package (projectM-jack) is APPROVED by oget ------------------------------------------------ Jameson, if you have time, could you review my package (Bug# 468765)? New Package CVS Request ======================= Package Name: projectM-jack Short Description: projectM visualizations for JACK audio Owners: imntreal Branches: F-9 F-10 InitialCC: imntreal > Jameson, if you have time, could you review my package (Bug# 468765)?
I'll start looking at it this week if no one else picks it up. That's actually one that I've been interested in.
cvs done. projectM-jack-1.2.0-4.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/projectM-jack-1.2.0-4.fc9 projectM-jack-1.2.0-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. projectM-jack-1.2.0-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/projectM-jack-1.2.0-4.fc10 projectM-jack-1.2.0-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |