Bug 464051 (projectM-jack) - Package Review Request for projectM-jack
Summary: Package Review Request for projectM-jack
Keywords:
Status: CLOSED NEXTRELEASE
Alias: projectM-jack
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Orcan Ogetbil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: libprojectM-qt
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-09-26 03:30 UTC by Jameson
Modified: 2008-12-03 01:10 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-11-19 14:51:40 UTC
Type: ---
Embargoed:
oget.fedora: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Jameson 2008-09-26 03:30:06 UTC
SPEC URL:  http://www.vtscrew.com/projectM-jack.spec
SRPM URL:  http://www.vtscrew.com/projectM-jack-1.2.0-1.fc9.src.rpm

Description:
This package allows the use of the projectM visualization plugin through any
JACK compatible applications.

No errors or warnings from rpmlint.

Comment 1 Jameson 2008-11-06 06:49:02 UTC
I have a new SPEC in original location, and a new SRPM:   http://www.vtscrew.com/projectM-jack-1.2.0-2.fc9.src.rpm

Comment 2 Jameson 2008-11-07 04:48:51 UTC
I have a new SPEC in original location, and a new SRPM:  
http://www.vtscrew.com/projectM-jack-1.2.0-3.fc9.src.rpm

Comment 3 Orcan Ogetbil 2008-11-08 04:20:44 UTC
This one is almost perfect. There are few little things to go through.

* URL has a typo

* Same subtleties apply for the license of this package as for the projectM-pulseaudio. "GPLv2+ and MIT" is fine but it would be good if we get a confirmation from upstream.

* I don't see any .la files built. You should remove that line.

* For the desktop file, please add
   Encoding=UTF-8
   Terminal=false
You use the same icon in the desktop file that you use for projectM-pulseaudio. You can require projectM-pulseaudio on this package, but that's not a nice solution. I think the best solution is renaming the icon file for this package.

Comment 4 Jameson 2008-11-12 01:29:24 UTC
I have a new SPEC in original location, and a new SRPM:  
http://www.vtscrew.com/projectM-jack-1.2.0-4.fc9.src.rpm

I double checked the URL, and it worked for me.  Am I still missing something in it?

I'm still waiting to hear from upstream about the license issues.  I'm afraid I've scared them off with it, though.

Sorry, I forgot that la files line.  I thought I got rid of all of them.

The desktop file is updated.  I didn't think I would need to require the pulseaudio package since the icon is actually installed with libprojectM-qt.

Comment 5 Jameson 2008-11-12 01:39:48 UTC
Oh URL, not SOURCE.  Gotcha

Comment 6 Orcan Ogetbil 2008-11-12 03:23:02 UTC
My bad, I thought the icon belongs to projectM-pulseaudio. Then there is no problem with the icon.

I will check this package probably tomorrow morning (EST).

Comment 7 Orcan Ogetbil 2008-11-12 16:16:48 UTC
All good!

------------------------------------------------
This package (projectM-jack) is APPROVED by oget
------------------------------------------------

Jameson, if you have time, could you review my package (Bug# 468765)?

Comment 8 Jameson 2008-11-13 00:25:40 UTC
New Package CVS Request
=======================
Package Name: projectM-jack
Short Description: projectM visualizations for JACK audio
Owners: imntreal
Branches: F-9 F-10
InitialCC: imntreal

Comment 9 Jameson 2008-11-13 00:26:16 UTC
> Jameson, if you have time, could you review my package (Bug# 468765)?

I'll start looking at it this week if no one else picks it up.  That's actually one that I've been interested in.

Comment 10 Kevin Fenzi 2008-11-14 05:44:02 UTC
cvs done.

Comment 11 Fedora Update System 2008-11-15 20:37:36 UTC
projectM-jack-1.2.0-4.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/projectM-jack-1.2.0-4.fc9

Comment 12 Fedora Update System 2008-11-19 14:51:37 UTC
projectM-jack-1.2.0-4.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2008-11-30 05:52:35 UTC
projectM-jack-1.2.0-4.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/projectM-jack-1.2.0-4.fc10

Comment 14 Fedora Update System 2008-12-03 01:10:26 UTC
projectM-jack-1.2.0-4.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.