Bug 466906
| Summary: | Review Request: perl-NOCpulse-SetID - Provides api for correctly changing user identity | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miroslav Suchý <msuchy> |
| Component: | Package Review | Assignee: | Dennis Gilmore <dennis> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, perl-devel, rc040203 |
| Target Milestone: | --- | Flags: | dennis:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-02-09 11:17:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 452450 | ||
|
Description
Miroslav Suchý
2008-10-14 13:18:42 UTC
Updated SRPM: http://miroslav.suchy.cz/fedora/perl-NOCpulse-SetID/perl-NOCpulse-SetID-1.5.6-1.f10.src.rpm SPEC: http://miroslav.suchy.cz/fedora/perl-NOCpulse-SetID/perl-NOCpulse-SetID.spec builds fine in mock, there is some issues though: There is no way to verify the license. The URL points at the generic spacewalk page and i could not find a page that talked about this package. at the least there should be a page for the tarball that has some contact info, a description and links to release tarballs. There really should be a LICENSE file in the tarball and a header on the souce .pm file and the test .pl file that state what the license is. Dennis com'on you are part of team which say under which license it is released. But OK: Updated SPEC http://miroslav.suchy.cz/fedora/perl-NOCpulse-SetID/perl-NOCpulse-SetID.spec Updated SRPM: http://miroslav.suchy.cz/fedora/perl-NOCpulse-SetID/perl-NOCpulse-SetID-1.6.8-1.f10.src.rpm There will be no page with description and links to released tarballs unless you will make it :) sorry for dropping the ball on this. Builds in mock source matches upstream. rpmlint is silent. sane Requires/Provides approved. New Package CVS Request ======================= Package Name: perl-NOCpulse-SetID Short Description: Provides api for correctly changing user identity Owners: msuchy Branches: devel F-10 EL-4 EL-5 InitialCC: Cvsextras Commits: yes (In reply to comment #4) > sane Requires/Provides Not quite :( Requires(pre): perl(Class::MethodMaker) This is very likely wrong. Furthermore: - Package is noarch => OPTIMIZE doesn't make any sense - Please add perl-sig to InitialCC like most perl-packagers do. - "make test" is claimed to require "root". I recommend to add an rpm option to run this testsuite (rpmbuild --with tests or similar). Better: Make the testsuite degrade gracefully if not being run as "root". > Requires(pre): perl(Class::MethodMaker) > This is very likely wrong. OK. There it seems that pure Requires: perl(Class::MethodMaker) Should be ok. > Package is noarch => OPTIMIZE doesn't make any sense OK. Will remove it. > Please add perl-sig to InitialCC like most perl-packagers do. I did not know it. I overlooked it in guidelines. Will do next time. > - "make test" is claimed to require "root". > I recommend to add an rpm option to run this testsuite All the test in this package require root. So making them optional will be the same as skipping it entirely. IMHO. (In reply to comment #7) > > Requires(pre): perl(Class::MethodMaker) > > This is very likely wrong. > > OK. There it seems that pure > Requires: perl(Class::MethodMaker) > Should be ok. No, it's entirely superfluous, rpm adds it automatically. You can completely remove it. > > Please add perl-sig to InitialCC like most perl-packagers do. > I did not know it. I overlooked it in guidelines. Will do next time. > > > - "make test" is claimed to require "root". > > I recommend to add an rpm option to run this testsuite > All the test in this package require root. Hmm, sounds like a pretty severe design problem with this package to me. > So making them optional will be the > same as skipping it entirely. IMHO. Not at all. It would enable those who want to build rpms as "root" (likely you) to test your package. cvs done. |